Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 555993002: disable webtry seccmp on non-linux build (Closed)

Created:
6 years, 3 months ago by humper
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

disable webtry seccmp on non-linux build BUG=skia: Committed: https://skia.googlesource.com/skia/+/d3b6eb246dce5a85c7a17a94e13f8aaca5729111

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove stray hashtag #

Patch Set 3 : rename safety flag to make it more clear what's going on #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M experimental/webtry/main.cpp View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M experimental/webtry/seccomp_bpf.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
humper
ptal
6 years, 3 months ago (2014-09-09 19:08:18 UTC) #2
mtklein
On 2014/09/09 19:08:18, humper wrote: > ptal This seems like not a good idea without ...
6 years, 3 months ago (2014-09-09 19:11:23 UTC) #3
jcgregorio
On 2014/09/09 19:11:23, mtklein wrote: > On 2014/09/09 19:08:18, humper wrote: > > ptal > ...
6 years, 3 months ago (2014-09-09 19:19:06 UTC) #4
jcgregorio
https://codereview.chromium.org/555993002/diff/1/experimental/webtry/main.cpp File experimental/webtry/main.cpp (right): https://codereview.chromium.org/555993002/diff/1/experimental/webtry/main.cpp#newcode15 experimental/webtry/main.cpp:15: # stray?
6 years, 3 months ago (2014-09-09 19:19:11 UTC) #5
humper
On 2014/09/09 19:11:23, mtklein wrote: > On 2014/09/09 19:08:18, humper wrote: > > ptal > ...
6 years, 3 months ago (2014-09-09 19:19:34 UTC) #6
humper
https://codereview.chromium.org/555993002/diff/1/experimental/webtry/main.cpp File experimental/webtry/main.cpp (right): https://codereview.chromium.org/555993002/diff/1/experimental/webtry/main.cpp#newcode15 experimental/webtry/main.cpp:15: # On 2014/09/09 19:19:11, jcgregorio wrote: > stray? Acknowledged. ...
6 years, 3 months ago (2014-09-09 19:21:23 UTC) #7
humper
On 2014/09/09 19:19:06, jcgregorio wrote: > On 2014/09/09 19:11:23, mtklein wrote: > > On 2014/09/09 ...
6 years, 3 months ago (2014-09-09 19:23:04 UTC) #8
humper
new flag created; once these patches land I'll start rejiggering how we build the actual ...
6 years, 3 months ago (2014-09-09 19:29:42 UTC) #9
jcgregorio
On 2014/09/09 19:29:42, humper wrote: > new flag created; once these patches land I'll start ...
6 years, 3 months ago (2014-09-09 19:31:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/555993002/40001
6 years, 3 months ago (2014-09-09 22:49:59 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 22:57:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as d3b6eb246dce5a85c7a17a94e13f8aaca5729111

Powered by Google App Engine
This is Rietveld 408576698