chrome/browser/resources/contextual_search/promo.js - Issue 555983002: [Search] Tweak the styling for the first-run experience

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/contextual_search/promo.js

Issue 555983002: [Search] Tweak the styling for the first-run experience (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/google_chrome_strings.grd ('K') | « chrome/browser/resources/contextual_search/promo.html ('k') | chrome/browser/search/contextual_search_promo_source_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/contextual_search/promo.js

diff --git a/chrome/browser/resources/contextual_search/promo.js b/chrome/browser/resources/contextual_search/promo.js

index dfdf1eff11cb81ffa5a248ceddd33a42f15a5157..5fa60ba1d2dad60d8d099d4e2b5334eb04bfa1d0 100644

--- a/chrome/browser/resources/contextual_search/promo.js

+++ b/chrome/browser/resources/contextual_search/promo.js

@@ -12,3 +12,11 @@ window.onload = function() {

$('container').classList.add('hide');

});

};

+/**

+ * Method called from Chrome to properly size the view.

huangs 2014/09/11 20:52:29 NIT: Mention what the method *does* before what it

Mathieu 2014/09/11 20:59:55 Done.

+ * @return {number} The height of the content, in pixels.

+ */

+function getContentHeight() {

+ return $('container').clientHeight;