[Search] Tweak the styling for the first-run experience

Improve wording, padding and general look and feel.

BUG=None

Committed: https://crrev.com/f7784c1bddb5820476febf29727a340e25c7f803
Cr-Commit-Position: refs/heads/master@{#294506}

[Mathieu, 2014-09-11 14:42:29]

mathp@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[Mathieu, 2014-09-11 14:42:49]

Hi Pedro, 

Let's start the review, thanks!

[pedro (no code reviews), 2014-09-11 20:33:23]

lgtm

LGTM with just a single nit.

You'll still need a committer's approval though.

https://codereview.chromium.org/555983002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.js (right):

https://codereview.chromium.org/555983002/diff/60001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.js:17: * @return {number} The
height of the content, in pixels.
Put a comment here explaining that this will be called from elsewhere.

[Mathieu, 2014-09-11 20:43:30]

mathp@chromium.org changed reviewers:
+ huangs@chromium.org

[Mathieu, 2014-09-11 20:43:45]

+sam

Sam, would you look/approve?

Thanks!

https://codereview.chromium.org/555983002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.js (right):

https://codereview.chromium.org/555983002/diff/60001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.js:17: * @return {number} The
height of the content, in pixels.
On 2014/09/11 20:33:22, pedrosimonetti wrote:
> Put a comment here explaining that this will be called from elsewhere.

Done.

[huangs, 2014-09-11 20:52:29]

LGTM with nits.

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1209: Using “Touch to Search” you can touch any
word on a website to learn more about a topic. Chromium will send that word and
the surrounding contents to Google and bring back relevant information about it.
Note the usage of fancy quotation mark (left and right).  Maybe these should be
escaped?

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1209: Using “Touch to Search” you can touch any
word on a website to learn more about a topic. Chromium will send that word and
the surrounding contents to Google and bring back relevant information about it.
Grammar: does the information refer to "that word" or "that word and the
surrounding contents"?  If latter, then should be "information about them.".

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1215: No thanks
NIT: Capitalization of "Search" and "thanks" inconsistent.

https://codereview.chromium.org/555983002/diff/80001/chrome/app/google_chrome...
File chrome/app/google_chrome_strings.grd (right):

https://codereview.chromium.org/555983002/diff/80001/chrome/app/google_chrome...
chrome/app/google_chrome_strings.grd:1134: Using “Touch to Search” you can touch
any word on a website to learn more about a topic. Chrome will send that word
and the surrounding contents to Google and bring back relevant information about
it.
Same comments are chromium_strings.grd.

https://codereview.chromium.org/555983002/diff/80001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.js (right):

https://codereview.chromium.org/555983002/diff/80001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.js:17: * Method called from
Chrome to properly size the view.
NIT: Mention what the method *does* before what it is used for.

[Mathieu, 2014-09-11 20:59:55]

Thanks. Addressed some nits, not all. Will submit.

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1209: Using “Touch to Search” you can touch any
word on a website to learn more about a topic. Chromium will send that word and
the surrounding contents to Google and bring back relevant information about it.
On 2014/09/11 20:52:29, huangs1 wrote:
> Note the usage of fancy quotation mark (left and right).  Maybe these should
be
> escaped?

It works well in the UI!

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1209: Using “Touch to Search” you can touch any
word on a website to learn more about a topic. Chromium will send that word and
the surrounding contents to Google and bring back relevant information about it.
On 2014/09/11 20:52:29, huangs1 wrote:
> Grammar: does the information refer to "that word" or "that word and the
> surrounding contents"?  If latter, then should be "information about them.".

information about the topic? UI people have vetted the string. Will ask them and
possibly change in a follow-up.

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1215: No thanks
On 2014/09/11 20:52:29, huangs1 wrote:
> NIT: Capitalization of "Search" and "thanks" inconsistent.

they are shown in CAPS in the UI, so not an issue. Still changed it.

https://codereview.chromium.org/555983002/diff/80001/chrome/app/google_chrome...
File chrome/app/google_chrome_strings.grd (right):

https://codereview.chromium.org/555983002/diff/80001/chrome/app/google_chrome...
chrome/app/google_chrome_strings.grd:1134: Using “Touch to Search” you can touch
any word on a website to learn more about a topic. Chrome will send that word
and the surrounding contents to Google and bring back relevant information about
it.
On 2014/09/11 20:52:29, huangs1 wrote:
> Same comments are chromium_strings.grd.

Done.

https://codereview.chromium.org/555983002/diff/80001/chrome/browser/resources...
File chrome/browser/resources/contextual_search/promo.js (right):

https://codereview.chromium.org/555983002/diff/80001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.js:17: * Method called from
Chrome to properly size the view.
On 2014/09/11 20:52:29, huangs1 wrote:
> NIT: Mention what the method *does* before what it is used for.

Done.

https://codereview.chromium.org/555983002/diff/80001/chrome/browser/resources...
chrome/browser/resources/contextual_search/promo.js:17: * Method called from
Chrome to properly size the view.
On 2014/09/11 20:52:29, huangs1 wrote:
> NIT: Mention what the method *does* before what it is used for.

Done.

[Mathieu, 2014-09-11 21:01:03]

The CQ bit was checked by mathp@chromium.org

[donnd, 2014-09-11 21:24:09]

donnd@google.com changed reviewers:
+ donnd@google.com

[donnd, 2014-09-11 21:24:09]

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/555983002/diff/80001/chrome/app/chromium_stri...
chrome/app/chromium_strings.grd:1209: Using “Touch to Search” you can touch any
word on a website to learn more about a topic. Chromium will send that word and
the surrounding contents to Google and bring back relevant information about it.
On 2014/09/11 20:59:55, Mathieu Perreault wrote:
> On 2014/09/11 20:52:29, huangs1 wrote:
> > Grammar: does the information refer to "that word" or "that word and the
> > surrounding contents"?  If latter, then should be "information about them.".
> 
> information about the topic? UI people have vetted the string. Will ask them
and
> possibly change in a follow-up.

I agree -- it's information about the topic -- I single search term that gets
identified by this process.  The surrounding contents help identify the topic
but are essentially ignored afterwards.

[commit-bot: I haz the power, 2014-09-11 21:31:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/555983002/100001

[commit-bot: I haz the power, 2014-09-12 00:45:02]

Committed patchset #6 (id:100001) as 3aed9dcde4bf32a28edb9f39eef094118c6eb42b

[commit-bot: I haz the power, 2014-09-12 00:51:53]

Patchset 6 (id:??) landed as
https://crrev.com/f7784c1bddb5820476febf29727a340e25c7f803
Cr-Commit-Position: refs/heads/master@{#294506}