Factor out Changelist GetStatus() for eventual use by other tools

Factor out Changelist GetStatus() for eventual use by other tools

Pulls the logic for computing an issue's "status" - has LGTM, is in
CQ, etc. - out of the "git cl status" command itself, so that other
tools can get the status of a Changelist.

BUG=379849
R=iannucci@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291928

[jsbell, 2014-09-10 00:15:56]

Please take a look?

Right now this should just be a refactor. Obviously, goal of this is to allow
things like git-map-branches -vvv

I haven't poked at tests yet. It doesn't appear we have any existing tests for
`git-cl status`, but perhaps I'm missing them?

[iannucci, 2014-09-10 19:10:39]

On 2014/09/10 00:15:56, jsbell wrote:
> Please take a look?
> 
> Right now this should just be a refactor. Obviously, goal of this is to allow
> things like git-map-branches -vvv
> 
> I haven't poked at tests yet. It doesn't appear we have any existing tests for
> `git-cl status`, but perhaps I'm missing them?

If they exist, CQ will let you know.

lgtm

[iannucci, 2014-09-10 19:10:57]

oops, forgot to publish

https://codereview.chromium.org/555973005/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/555973005/diff/20001/git_cl.py#newcode858
git_cl.py:858: reviewers = self.GetApprovingReviewers()
since this makes a second HTTP request (I think), let's do this after we pass
the first block of returns.

https://codereview.chromium.org/555973005/diff/20001/git_cl.py#newcode1334
git_cl.py:1334: }[status]
let's factor this list out too so that git-map-branches can use it

[jsbell, 2014-09-10 22:00:27]

Thanks. Take another look to see if the tweaks/formatting look good?

https://codereview.chromium.org/555973005/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/555973005/diff/20001/git_cl.py#newcode858
git_cl.py:858: reviewers = self.GetApprovingReviewers()
On 2014/09/10 19:10:57, iannucci wrote:
> since this makes a second HTTP request (I think), let's do this after we pass
> the first block of returns.

Done.

https://codereview.chromium.org/555973005/diff/20001/git_cl.py#newcode1334
git_cl.py:1334: }[status]
On 2014/09/10 19:10:57, iannucci wrote:
> let's factor this list out too so that git-map-branches can use it

Done.

[iannucci, 2014-09-10 22:44:31]

lgtm

https://codereview.chromium.org/555973005/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/555973005/diff/40001/git_cl.py#newcode1279
git_cl.py:1279: }[status]
why not just put error in here and then just do

return {
  ...
}.get(status, Fore.WHITE)

[jsbell, 2014-09-11 17:27:15]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-09-11 17:27:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/555973005/60001

[jsbell, 2014-09-11 17:27:55]

Thanks!

https://codereview.chromium.org/555973005/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/555973005/diff/40001/git_cl.py#newcode1279
git_cl.py:1279: }[status]
On 2014/09/10 22:44:30, iannucci wrote:
> why not just put error in here and then just do
> 
> return {
>   ...
> }.get(status, Fore.WHITE)

Done.

[commit-bot: I haz the power, 2014-09-11 17:29:29]

Committed patchset #4 (id:60001) as 291928