Issue 555953002: Move isLoading() from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555953002: Move isLoading() from WebFrame to WebLocalFrame (Closed)

Created:
6 years, 3 months ago by Nate Chapin

Modified:
6 years, 3 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-reviews, dcheng, dglazkov+blink, jamesr, mlamouri (slow - plz ping)

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Move isLoading() from WebFrame to WebLocalFrame It is a concept that doesn't make sense for a remote frame (whether the load event has fired), and all callsites are using WebLocalFrames BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181689

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -10 lines)			Patch
M	Source/web/WebRemoteFrameImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebRemoteFrameImpl.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	public/web/WebFrame.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	public/web/WebLocalFrame.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/555953002/1

6 years, 3 months ago (2014-09-09 23:32:20 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 00:25:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181689

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages