Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 555933002: Avoid ForceHorriblySlowRectMapping in RenderInline::clippedOverflowRectForPaintInvalidation() (Closed)

Created:
6 years, 3 months ago by Xianzhu
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Avoid ForceHorriblySlowRectMapping in RenderInline::clippedOverflowRectForPaintInvalidation() ForceHorriblySlowRectMapping was needed in RenderInline:: clippedOverflowRectForPaintInvalidation() to avoid errors when calling containingBlock->mapRectToPaintInvalidationBacking() with the provided paintInvalidationState. Now call RenderInline's own mapRectToPaintInvalidationBacking() instead of containingBlock's to make paintInvalidationState applicable and reduce duplicate code. BUG=402994 TEST=exsiting tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -27 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Xianzhu
6 years, 3 months ago (2014-09-09 17:06:12 UTC) #2
Xianzhu
ping...
6 years, 3 months ago (2014-09-10 17:19:52 UTC) #3
Xianzhu
On 2014/09/10 17:19:52, Xianzhu wrote: > ping... ping...
6 years, 3 months ago (2014-09-11 17:39:59 UTC) #4
leviw_travelin_and_unemployed
typos in description: "exsisting" and "containeingBlock" The change seems great, but I'd feel a lot ...
6 years, 3 months ago (2014-09-12 01:07:09 UTC) #5
Xianzhu
On 2014/09/12 01:07:09, leviw wrote: > typos in description: "exsisting" and "containeingBlock" > Done. > ...
6 years, 3 months ago (2014-09-12 02:01:19 UTC) #6
leviw_travelin_and_unemployed
lgtm
6 years, 3 months ago (2014-09-12 18:06:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555933002/1
6 years, 3 months ago (2014-09-12 18:07:11 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 18:29:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181921

Powered by Google App Engine
This is Rietveld 408576698