Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 555923002: [Mac] Set the avatar button auth error before initially drawing the button. (Closed)

Created:
6 years, 3 months ago by noms (inactive)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Set the avatar button auth error before initially drawing the button. Otherwise when opening a new window (and initially drawing it), the button will not take the auth error icon's size in consideration. BUG=411962 Committed: https://crrev.com/fab5d305c83aa6b7ad70800d450b46c54dd31ddf Cr-Commit-Position: refs/heads/master@{#293969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
6 years, 3 months ago (2014-09-09 15:59:35 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-09 17:08:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/555923002/1
6 years, 3 months ago (2014-09-09 17:13:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5bf72a25a0fc938197960c5cbc55d39da77af58c
6 years, 3 months ago (2014-09-09 18:21:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fab5d305c83aa6b7ad70800d450b46c54dd31ddf
Cr-Commit-Position: refs/heads/master@{#293969}

Powered by Google App Engine
This is Rietveld 408576698