Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 555883002: Reland "Go back to old underline position and thickness logic" (Closed)

Created:
6 years, 3 months ago by eae
Modified:
6 years, 3 months ago
Reviewers:
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reland "Go back to old underline position and thickness logic" In r174431 from May this year we changed the underline position and thickness logic to respect the underline data specified in the font. While this improved rendering for certain fonts and scripts it did cause a regression for others. This change reverts to the old behavior while we figure out how to handle fonts with inaccurate or undesirable metrics. BUG=408075 TBR=keishi@chromium.org Committed as r181591 and reverted in r181607 due to missing XP expectations. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+542 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +542 lines, -2 lines 0 comments Download
M Source/platform/fonts/skia/SimpleFontDataSkia.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/555883002/1
6 years, 3 months ago (2014-09-09 15:31:54 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 17:35:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181659

Powered by Google App Engine
This is Rietveld 408576698