Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 555853003: Roll gyp r1972:1974 (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll gyp r1972:1974 r1974: Changes ninja generator to only output empty names if not already output r1973: Changes the ninja generator to output phony targets for uninteresting targets BUG=410410 TEST=none R=thakis@chromium.org TBR=thakis@chromium.org Committed: https://crrev.com/48292ce2adf6c38c356ab97a517fd9bfde4070e4 Cr-Commit-Position: refs/heads/master@{#293957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
6 years, 3 months ago (2014-09-09 15:23:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/555853003/1
6 years, 3 months ago (2014-09-09 15:25:01 UTC) #3
Nico
lgtm On Tue, Sep 9, 2014 at 8:25 AM, <commit-bot@chromium.org> wrote: > CQ is trying ...
6 years, 3 months ago (2014-09-09 15:37:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as c57a081d143fee3cc5ffc82d1a84f8c920c72b3f
6 years, 3 months ago (2014-09-09 17:13:19 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48292ce2adf6c38c356ab97a517fd9bfde4070e4
Cr-Commit-Position: refs/heads/master@{#293957}

Powered by Google App Engine
This is Rietveld 408576698