Shrink Document::parseQualifiedName a bit.

Shrink Document::parseQualifiedName a bit.

It duplicated a large code chunk by using a templated function full of 
generic code both for UChar and LChar. By extracting the generic code
to the caller the amount of duplicate code was greatly reduced. With clang
the function shrunk from 5 KB to 2.5 KB (which is still large but not crazy
large).

-----------------------------------------------------------------------------------------------------------------------
 -2196 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp - (gained 0, lost 2196)
-----------------------------------------------------------------------------------------------------------------------
  Shrunk symbols:
      -2196: blink::Document::parseQualifiedName(WTF::AtomicString const&, WTF::AtomicString&, WTF::AtomicString&, blink::ExceptionState&) type=t, (was 4808 bytes, now 2612 bytes)

BUG=
R=fs@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182043

[Daniel Bratell, 2014-09-10 15:52:53]

Patchset #1 (id:1) has been deleted

[Daniel Bratell, 2014-09-10 16:40:26]

bratell@opera.com changed reviewers:
+ fs@opera.com

[Daniel Bratell, 2014-09-10 16:40:27]

Followup to https://codereview.chromium.org/387313002/

It's not very beautiful. Maybe there is a better way of doing this.

[Daniel Bratell, 2014-09-10 16:40:29]

Followup to https://codereview.chromium.org/387313002/

It's not very beautiful. Maybe there is a better way of doing this.

[fs, 2014-09-11 09:17:48]

https://codereview.chromium.org/555813003/diff/20001/Source/core/dom/Document...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/555813003/diff/20001/Source/core/dom/Document...
Source/core/dom/Document.cpp:4210: enum ParseQualifiedNameException {
Lots of "Exception" here, maybe it'd be possible to drop the "Exception" part(s)
in favor of some other term (status?), and then leave
Document::parseQualifiedName to deal with exception bits. ("PQNNoException"
would then be be something like "PQNValid" or "PQNSuccess" - or maybe even using
"QName" as a prefix could work here - giving "QNameValid" etc.)

https://codereview.chromium.org/555813003/diff/20001/Source/core/dom/Document...
Source/core/dom/Document.cpp:4223:
ParseQualifiedNameResult(ParseQualifiedNameException result) : result(result) {
}
Coding-style dictates the use of explicit here. Not using it would of course
allow for slightly "nicer" code in most of the error cases below - but also lead
to inconsistencies with the invalid-char cases...

https://codereview.chromium.org/555813003/diff/20001/Source/core/dom/Document...
Source/core/dom/Document.cpp:4292: if (returnValue.result ==
PQNMultipleColonsException) {
I suspect that using a switch here might give slightly less "busy" code
(result-values lining up for instance) - and hopefully not affect code-gen. I'll
let you decide though =)

[fs, 2014-09-15 16:20:18]

lgtm

[Daniel Bratell, 2014-09-16 08:13:54]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-09-16 08:15:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/555813003/40001

[commit-bot: I haz the power, 2014-09-16 09:32:34]

Committed patchset #2 (id:40001) as 182043