Don't record slots of objects that may contain raw values.

Don't record slots of objects that may contain raw values.

BUG=
R=mstarzinger@chromium.org, yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23791

[Hannes Payer (out of office), 2014-09-09 08:44:50]

hpayer@chromium.org changed reviewers:
+ mstarzinger@chromium.org, yangguo@chromium.org

[Yang, 2014-09-09 08:55:06]

On 2014/09/09 08:44:51, Hannes Payer wrote:

lgtm.

[Michael Starzinger, 2014-09-09 09:41:29]

https://codereview.chromium.org/555783002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/555783002/diff/1/src/objects.h#newcode1745
src/objects.h:1745: inline bool MayContainRawValues();
Both the name and the comment seem to describe exactly the opposite of the
implemented behavior.

[Hannes Payer (out of office), 2014-09-09 09:56:41]

https://codereview.chromium.org/555783002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/555783002/diff/1/src/objects.h#newcode1745
src/objects.h:1745: inline bool MayContainRawValues();
On 2014/09/09 09:41:29, Michael Starzinger wrote:
> Both the name and the comment seem to describe exactly the opposite of the
> implemented behavior.

Done.

[Michael Starzinger, 2014-09-09 10:00:08]

LGTM, just two more comments are still out of date.

https://codereview.chromium.org/555783002/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/555783002/diff/20001/src/objects-inl.h#newcod...
src/objects-inl.h:1485: // Only the latter two contain non-map-word pointers to
heap objects.
nit: s/the latter two contain non-map-word pointers to heap objects/the former
two contain raw values and no heap pointers (besides the map-word)/

https://codereview.chromium.org/555783002/diff/20001/src/objects-inl.h#newcod...
src/objects-inl.h:1488: // The ConstantPoolArray contains heap pointers, but not
new space pointers.
nit: s/but not new space pointers/but also raw values/

[Hannes Payer (out of office), 2014-09-09 10:05:16]

https://codereview.chromium.org/555783002/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/555783002/diff/20001/src/objects-inl.h#newcod...
src/objects-inl.h:1485: // Only the latter two contain non-map-word pointers to
heap objects.
On 2014/09/09 10:00:08, Michael Starzinger wrote:
> nit: s/the latter two contain non-map-word pointers to heap objects/the former
> two contain raw values and no heap pointers (besides the map-word)/

Done.

https://codereview.chromium.org/555783002/diff/20001/src/objects-inl.h#newcod...
src/objects-inl.h:1488: // The ConstantPoolArray contains heap pointers, but not
new space pointers.
On 2014/09/09 10:00:08, Michael Starzinger wrote:
> nit: s/but not new space pointers/but also raw values/

Done.

[Hannes Payer (out of office), 2014-09-09 10:07:39]

Committed patchset #3 (id:40001) manually as 23791 (presubmit successful).