Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 555733003: [Mac] Chrome print dialog disregards system cancel key-command. (Closed)

Created:
6 years, 3 months ago by Gaja
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Chrome print dialog disregards system cancel key-command. Add support for Cmd- (the universal "cancel" shortcut on Mac) to close print dialog. BUG=249786 R=dpapad@chromium.org TEST= 1. Open a web page 2. Hit Cmd-P to bring up print dialog. 3. Hit Cmd- and observe. 4. The print dialog should get closed. Committed: https://crrev.com/4b0e06faa400dcb73275098d17d2c523e7625fd6 Cr-Commit-Position: refs/heads/master@{#294142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Gaja
PTAL.
6 years, 3 months ago (2014-09-09 08:53:27 UTC) #1
Lei Zhang
+alekseys
6 years, 3 months ago (2014-09-09 19:45:43 UTC) #3
Aleksey Shlyapnikov
lgtm
6 years, 3 months ago (2014-09-09 20:45:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/555733003/1
6 years, 3 months ago (2014-09-10 02:41:14 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-10 02:41:16 UTC) #8
Lei Zhang
lgtm stamp
6 years, 3 months ago (2014-09-10 06:47:56 UTC) #9
Gaja
On 2014/09/10 06:47:56, Lei Zhang wrote: > lgtm stamp @Aleksey Shlyapnikov @Lei Zhang Thanks!. Can ...
6 years, 3 months ago (2014-09-10 06:52:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gajendra.n@samsung.com/555733003/1
6 years, 3 months ago (2014-09-10 06:58:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4fbcfe02319e4b872c691e7424c309224a5a7d27
6 years, 3 months ago (2014-09-10 08:12:06 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:56:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b0e06faa400dcb73275098d17d2c523e7625fd6
Cr-Commit-Position: refs/heads/master@{#294142}

Powered by Google App Engine
This is Rietveld 408576698