Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 555733002: AX: Add accessibility label strings for calendar picker. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AX: Add accessibility label strings for calendar picker. Will add layout tests to Blink after this CL. BUG=123896 Committed: https://crrev.com/82d00f0d5391fd8eafcd03118bac38cbac8a19e4 Cr-Commit-Position: refs/heads/master@{#294120}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : n #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/app/strings/content_strings.grd View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tkent
Keishi, would you do non-owner review please? Jochen, would you approve this please? This CL ...
6 years, 3 months ago (2014-09-09 08:05:49 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-09 09:01:07 UTC) #4
keishi
lgtm https://codereview.chromium.org/555733002/diff/20001/content/app/strings/content_strings.grd File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/555733002/diff/20001/content/app/strings/content_strings.grd#newcode325 content/app/strings/content_strings.grd:325: <message name="IDS_AX_CALENDAR_SHOW_MONTH_SELECTOR" desc="Accessible description of a button to ...
6 years, 3 months ago (2014-09-10 03:04:44 UTC) #5
tkent
https://codereview.chromium.org/555733002/diff/20001/content/app/strings/content_strings.grd File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/555733002/diff/20001/content/app/strings/content_strings.grd#newcode325 content/app/strings/content_strings.grd:325: <message name="IDS_AX_CALENDAR_SHOW_MONTH_SELECTOR" desc="Accessible description of a button to show ...
6 years, 3 months ago (2014-09-10 03:07:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/555733002/40001
6 years, 3 months ago (2014-09-10 03:08:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 605cf9f6817edf1c03504a4e3dd5275ea45414e4
6 years, 3 months ago (2014-09-10 06:16:48 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 06:22:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82d00f0d5391fd8eafcd03118bac38cbac8a19e4
Cr-Commit-Position: refs/heads/master@{#294120}

Powered by Google App Engine
This is Rietveld 408576698