Add STATE_MAXIMIZED to the list of possible window states in MapWindow().

Add STATE_MAXIMIZED to the list of possible window states in MapWindow().

This gets rid of console warning on startup when maximized.

BUG=

Committed: https://crrev.com/e3db4d16a382d97c709b593638247b42ddf62207
Cr-Commit-Position: refs/heads/master@{#294558}

[joleksy, 2014-09-09 07:36:23]

joleksy@opera.com changed reviewers:
+ erg@chromium.org

[joleksy, 2014-09-09 07:36:40]

@reviewer: does it look ok to you?

[Elliot Glaysher, 2014-09-09 17:22:20]

On 2014/09/09 07:36:40, joleksy wrote:
> @reviewer: does it look ok to you?

Do we actually handle STATE_MAXIMIZED in this function, though?

[joleksy, 2014-09-10 06:51:59]

On 2014/09/09 17:22:20, Elliot Glaysher wrote:
> On 2014/09/09 07:36:40, joleksy wrote:
> > @reviewer: does it look ok to you?
> 
> Do we actually handle STATE_MAXIMIZED in this function, though?

The comment for this case says:
// It will behave like SHOW_STATE_NORMAL.

The window is mapped and all so I guess we do handle it, the fix is just to get
rid of console warning.

[Elliot Glaysher, 2014-09-10 17:41:43]

On 2014/09/10 06:51:59, joleksy wrote:
> On 2014/09/09 17:22:20, Elliot Glaysher wrote:
> > On 2014/09/09 07:36:40, joleksy wrote:
> > > @reviewer: does it look ok to you?
> > 
> > Do we actually handle STATE_MAXIMIZED in this function, though?
> 
> The comment for this case says:
> // It will behave like SHOW_STATE_NORMAL.
> 
> The window is mapped and all so I guess we do handle it, the fix is just to
get
> rid of console warning.

No, I mean that in cases where we call MapWindow(STATE_MAXIMIZED), does the
window end up maximized? If it doesn't, then the console warning is correct and
shouldn't be removed.

[joleksy, 2014-09-11 06:52:22]

On 2014/09/10 17:41:43, Elliot Glaysher wrote:
> On 2014/09/10 06:51:59, joleksy wrote:
> > On 2014/09/09 17:22:20, Elliot Glaysher wrote:
> > > On 2014/09/09 07:36:40, joleksy wrote:
> > > > @reviewer: does it look ok to you?
> > > 
> > > Do we actually handle STATE_MAXIMIZED in this function, though?
> > 
> > The comment for this case says:
> > // It will behave like SHOW_STATE_NORMAL.
> > 
> > The window is mapped and all so I guess we do handle it, the fix is just to
> get
> > rid of console warning.
> 
> No, I mean that in cases where we call MapWindow(STATE_MAXIMIZED), does the
> window end up maximized? If it doesn't, then the console warning is correct
and
> shouldn't be removed.

Yes, the window is maximized properly.

[Elliot Glaysher, 2014-09-11 17:17:31]

lgtm

[joleksy, 2014-09-12 06:21:42]

The CQ bit was checked by joleksy@opera.com

[commit-bot: I haz the power, 2014-09-12 06:21:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/555723003/1

[commit-bot: I haz the power, 2014-09-12 09:27:14]

Committed patchset #1 (id:1) as 707e8c525707b1db9372c804cd0cc9d1dca9e60f

[commit-bot: I haz the power, 2014-09-12 09:29:19]

Patchset 1 (id:??) landed as
https://crrev.com/e3db4d16a382d97c709b593638247b42ddf62207
Cr-Commit-Position: refs/heads/master@{#294558}