Source/modules/webmidi/MIDIPortMap.h - Issue 555683003: MIDI{Input, Output}Map[Symbol.iterator]() should return entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIPortMap.h

Issue 555683003: MIDI{Input, Output}Map[Symbol.iterator]() should return entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/MIDIPortMap.h

diff --git a/Source/modules/webmidi/MIDIPortMap.h b/Source/modules/webmidi/MIDIPortMap.h

index c70b50b71c9bc07b0058aaa91a6451938e236ab0..d0fd5faa8bf909c8c8ad75f4f13f10a2a1085807 100644

--- a/Source/modules/webmidi/MIDIPortMap.h

+++ b/Source/modules/webmidi/MIDIPortMap.h

@@ -29,7 +29,7 @@ public:

Iterator* values();

T* get(const String& key) const;

bool has(const String& key) const { return m_entries.contains(key); }

- Iterator* iterator(ScriptState*, ExceptionState&) { return values(); }

+ Iterator* iterator(ScriptState*, ExceptionState&) { return entries(); }

void trace(Visitor* visitor)

{

« LayoutTests/webmidi/requestmidiaccess.html ('K') | « LayoutTests/webmidi/send_messages.html ('k') | no next file » | no next file with comments »