Issue 555663002: Enhance the MachMessageServer test to cover port right ownership management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555663002: Enhance the MachMessageServer test to cover port right ownership management (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Enhance the MachMessageServer test to cover port right ownership management. TEST=util_test MachMessageServer.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/88a681e7479fb7c6458fb87416c1d3981ceb3f6e

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -15 lines)			Patch
	M	util/mach/mach_message_server.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	util/mach/mach_message_server_test.cc	View		14 chunks	+217 lines, -15 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Robert Sesek

LGTM. This test exemplifies many things that over-complicate Mach messaging. https://codereview.chromium.org/555663002/diff/1/util/mach/mach_message_server_test.cc File util/mach/mach_message_server_test.cc (right): https://codereview.chromium.org/555663002/diff/1/util/mach/mach_message_server_test.cc#newcode615 ...

6 years, 3 months ago (2014-09-09 02:49:30 UTC) #3

Mark Mentovai

6 years, 3 months ago (2014-09-09 13:59:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 88a681e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages