Fix URLRequestHttpJob to use ScopedRunnableMethodFactory.

Fix URLRequestHttpJob to use ScopedRunnableMethodFactory.

This will prevent us from leaking SSLClientSockets on shutdown since the certificate related functions complete asynchronously.  There's no reason to keep the URLRequestHttpJob alive, since Kill() will cancel the delegates appropriately, so we use ScopedRunnableMethodFactory to avoid AddRef()'ing when we PostTask().

BUG=63692
TEST=existing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68153

[willchan no longer on Chromium, 2010-12-03 00:51:08]

eroman: primary reviewer
rdsmith: secondary reviewer, just to help you learn the code.  You'll find it
useful to look at the URLRequestJob::Kill() and URLRequestHttpJob::Kill() to see
how cancellation works.

akalin: FYI

[eroman, 2010-12-03 06:03:19]

lgtm

http://codereview.chromium.org/5556004/diff/1/net/url_request/url_request_htt...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/5556004/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:376:
&URLRequestHttpJob::OnStartCompleted, net::OK));
nit: indent by 4

[Randy Smith (Not in Mondays), 2010-12-06 20:49:27]

On 2010/12/03 00:51:08, willchan wrote:
> eroman: primary reviewer
> rdsmith: secondary reviewer, just to help you learn the code.  You'll find it
> useful to look at the URLRequestJob::Kill() and URLRequestHttpJob::Kill() to
see
> how cancellation works.
> 
> akalin: FYI

LGTM.  What more would be required to stop URLRequestJob from being
RefCounted<>?

[Randy Smith (Not in Mondays), 2010-12-06 21:12:17]

On 2010/12/06 20:49:27, rdsmith wrote:
> On 2010/12/03 00:51:08, willchan wrote:
> > eroman: primary reviewer
> > rdsmith: secondary reviewer, just to help you learn the code.  You'll find
it
> > useful to look at the URLRequestJob::Kill() and URLRequestHttpJob::Kill() to
> see
> > how cancellation works.
> > 
> > akalin: FYI
> 
> LGTM.  What more would be required to stop URLRequestJob from being
> RefCounted<>?

Never mind--I think the answer's implicit in the other patches.