Cast: Flow hw encoder initialization error to extensions API

Cast: Flow hw encoder initialization error to extensions API

cast.streaming API will be notified if there is a hardware
initialization error. This way extension can decide whether to restart
with a different codec or just fail.

Also fixed a small issue that Framer is printing too many messages.

BUG=402182
Committed: https://crrev.com/42d3637eb8a7a82ac5a3183272224b6c2b5f2249
Cr-Commit-Position: refs/heads/master@{#294216}

[Alpha Left Google, 2014-09-09 00:14:18]

hclam@chromium.org changed reviewers:
+ hubbe@chromium.org

[hubbe, 2014-09-09 00:25:45]

https://codereview.chromium.org/555563003/diff/40001/chrome/renderer/media/ca...
File chrome/renderer/media/cast_session_delegate.cc (right):

https://codereview.chromium.org/555563003/diff/40001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:50: default:
Remove the default so that we get a compile error if we don't cover all cases.

https://codereview.chromium.org/555563003/diff/40001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:236: if (result ==
media::cast::STATUS_AUDIO_INITIALIZED) {
might be better to just inline CastErrorToString here...

https://codereview.chromium.org/555563003/diff/40001/media/cast/sender/video_...
File media/cast/sender/video_sender.h (right):

https://codereview.chromium.org/555563003/diff/40001/media/cast/sender/video_...
media/cast/sender/video_sender.h:47: CastInitializationStatus
InitializationResult() const {
Do we need this anymore?

[Alpha Left Google, 2014-09-09 00:37:11]

https://codereview.chromium.org/555563003/diff/40001/chrome/renderer/media/ca...
File chrome/renderer/media/cast_session_delegate.cc (right):

https://codereview.chromium.org/555563003/diff/40001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:50: default:
On 2014/09/09 00:25:45, hubbe wrote:
> Remove the default so that we get a compile error if we don't cover all cases.

Done.

https://codereview.chromium.org/555563003/diff/40001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:236: if (result ==
media::cast::STATUS_AUDIO_INITIALIZED) {
On 2014/09/09 00:25:45, hubbe wrote:
> might be better to just inline CastErrorToString here...

Done.

https://codereview.chromium.org/555563003/diff/40001/media/cast/sender/video_...
File media/cast/sender/video_sender.h (right):

https://codereview.chromium.org/555563003/diff/40001/media/cast/sender/video_...
media/cast/sender/video_sender.h:47: CastInitializationStatus
InitializationResult() const {
On 2014/09/09 00:25:45, hubbe wrote:
> Do we need this anymore?

Removed.

[hubbe, 2014-09-09 19:11:03]

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
File chrome/renderer/media/cast_session_delegate.cc (right):

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:210: if (result ==
media::cast::STATUS_AUDIO_INITIALIZED) {
Make this part of the switch() ?

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:219: error_callback.Run("Invalid
cast environment.");
break?

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:221: error_callback.Run("Invalid
encryption keys.");
break?

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:223: error_callback.Run("Audio
codec not supported.");
break?

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:225: error_callback.Run("Video
codec not supported.");
break?

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:227: error_callback.Run("Invalid
audio configuration.");
break?

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:229: error_callback.Run("Invalid
video configuration.");
break?

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:231: error_callback.Run("Hardware
video encoder not supported.");
break?

https://codereview.chromium.org/555563003/diff/60001/media/cast/sender/video_...
File media/cast/sender/video_sender.h (left):

https://codereview.chromium.org/555563003/diff/60001/media/cast/sender/video_...
media/cast/sender/video_sender.h:47: return cast_initialization_status_;
Can we get rid of this function on the audio side too?
And maybe the variable too?

[Alpha Left Google, 2014-09-09 19:41:18]

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
File chrome/renderer/media/cast_session_delegate.cc (right):

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:210: if (result ==
media::cast::STATUS_AUDIO_INITIALIZED) {
On 2014/09/09 19:11:03, hubbe wrote:
> Make this part of the switch() ?

Done.

https://codereview.chromium.org/555563003/diff/60001/chrome/renderer/media/ca...
chrome/renderer/media/cast_session_delegate.cc:219: error_callback.Run("Invalid
cast environment.");
On 2014/09/09 19:11:03, hubbe wrote:
> break?

Whooooops. Done.

https://codereview.chromium.org/555563003/diff/60001/media/cast/sender/video_...
File media/cast/sender/video_sender.h (left):

https://codereview.chromium.org/555563003/diff/60001/media/cast/sender/video_...
media/cast/sender/video_sender.h:47: return cast_initialization_status_;
On 2014/09/09 19:11:03, hubbe wrote:
> Can we get rid of this function on the audio side too?
> And maybe the variable too?

Audio initialization status actually is in use, it checks the configuration to
make sure it's valid.

[hubbe, 2014-09-09 20:11:11]

lgtm

[Alpha Left Google, 2014-09-09 22:22:42]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-09-09 22:23:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/555563003/80001

[commit-bot: I haz the power, 2014-09-09 22:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 22:29:50]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/53677)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Alpha Left Google, 2014-09-09 23:43:08]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-09-09 23:51:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/555563003/100001

[commit-bot: I haz the power, 2014-09-10 00:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 00:26:33]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/53744)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/58700)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Alpha Left Google, 2014-09-10 19:03:37]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-09-10 19:05:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/555563003/120001

[commit-bot: I haz the power, 2014-09-10 20:33:01]

Committed patchset #7 (id:120001) as cb91e2509ebf045b414f2cdf56a29492fd8b153e

[commit-bot: I haz the power, 2014-09-10 20:40:25]

Patchset 7 (id:??) landed as
https://crrev.com/42d3637eb8a7a82ac5a3183272224b6c2b5f2249
Cr-Commit-Position: refs/heads/master@{#294216}