Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 555553003: Minor compiler pipeline refactoring. Inline UpdateSharedFunctionInfo and make Parser::Parse respons… (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Minor compiler pipeline refactoring. Inline UpdateSharedFunctionInfo and make Parser::Parse responsible for setting the strict mode of the CompilationInfo. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24001

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove more uses of setting the strictness in the compilation info. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -52 lines) Patch
M src/compiler.cc View 4 chunks +22 lines, -37 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/parser.h View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/osr-warm.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
6 years, 3 months ago (2014-09-17 11:57:47 UTC) #1
Michael Starzinger
LGTM (if at least the first comment is addressed). https://codereview.chromium.org/555553003/diff/1/src/compiler.cc File src/compiler.cc (left): https://codereview.chromium.org/555553003/diff/1/src/compiler.cc#oldcode820 src/compiler.cc:820: ...
6 years, 3 months ago (2014-09-17 12:10:10 UTC) #2
titzer
https://codereview.chromium.org/555553003/diff/1/src/compiler.cc File src/compiler.cc (left): https://codereview.chromium.org/555553003/diff/1/src/compiler.cc#oldcode820 src/compiler.cc:820: info.SetStrictMode(info.function()->strict_mode()); On 2014/09/17 12:10:10, Michael Starzinger wrote: > This ...
6 years, 3 months ago (2014-09-17 12:18:17 UTC) #3
titzer
6 years, 3 months ago (2014-09-17 12:35:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 24001 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698