Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 555553002: Add new isolation mode "prepare". (Closed)

Created:
6 years, 3 months ago by Vadim Sh.
Modified:
6 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add new isolation mode "prepare". In that mode isolate_driver.py will collect all arguments needed for isolate.py invocation into *.isolated.gen.json file, but won't actually run the isolation itself. It's a feature of isolate_driver.py. Isolate client itself knows nothing about this mode. BUG=389227 R=maruel@chromium.org Committed: https://crrev.com/8556ebdc21ada4753aa6798a240c83101f212dcf Cr-Commit-Position: refs/heads/master@{#293885}

Patch Set 1 #

Patch Set 2 : make version integer #

Total comments: 2

Patch Set 3 : wt -> wb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M build/isolate.gypi View 2 chunks +11 lines, -4 lines 0 comments Download
M tools/isolate_driver.py View 1 2 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Vadim Sh.
ptal generates a file that looks like this: { "args": [ "--isolated", "../out/Debug/base_unittests.isolated", "--isolate", "base_unittests.isolate", ...
6 years, 3 months ago (2014-09-08 21:45:00 UTC) #1
Vadim Sh.
actually wait a bit, I'm writing isolate.py side of this. And it might be easier ...
6 years, 3 months ago (2014-09-08 22:19:02 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/555553002/diff/20001/tools/isolate_driver.py File tools/isolate_driver.py (right): https://codereview.chromium.org/555553002/diff/20001/tools/isolate_driver.py#newcode257 tools/isolate_driver.py:257: with open(output, 'wt') as f: Why not 'wb'? ...
6 years, 3 months ago (2014-09-08 22:40:29 UTC) #3
Vadim Sh.
I decided to commit this as is (i.e. JSON contains command line). https://codereview.chromium.org/555553002/diff/20001/tools/isolate_driver.py File tools/isolate_driver.py ...
6 years, 3 months ago (2014-09-08 23:57:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/555553002/40001
6 years, 3 months ago (2014-09-09 00:28:48 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as bc3cb6bd399df5e55629e3d656aadafd0b6fc911
6 years, 3 months ago (2014-09-09 07:25:08 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8556ebdc21ada4753aa6798a240c83101f212dcf
Cr-Commit-Position: refs/heads/master@{#293885}

Powered by Google App Engine
This is Rietveld 408576698