Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 555543003: ui/gfx: Remove duplicated win condition. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, Ben Goodger (Google), brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: Remove duplicated win condition. We already have the same msvs_disabled_warnings declared at line 172. No need to have it twice. BUG=331829 TEST=gfx_unittests TBR=sky@chromium.org Committed: https://crrev.com/917b312e36bdebde4d92bf8bcc1e070b5d064f54 Cr-Commit-Position: refs/heads/master@{#294756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ui/gfx/gfx_tests.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
TBRing...
6 years, 3 months ago (2014-09-13 20:07:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555543003/1
6 years, 3 months ago (2014-09-13 20:09:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 746449054b89a075b1271eaf24ecf06550b1b314
6 years, 3 months ago (2014-09-13 21:05:41 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 21:09:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/917b312e36bdebde4d92bf8bcc1e070b5d064f54
Cr-Commit-Position: refs/heads/master@{#294756}

Powered by Google App Engine
This is Rietveld 408576698