Componentize component_updater: Enable tests on iOS.

Componentize component_updater: Enable tests on iOS.

BUG=371463
Committed: https://crrev.com/43754386adfac6ca796478cd0b68947a8be599cb
Cr-Commit-Position: refs/heads/master@{#294184}

[tommycli, 2014-09-09 17:31:09]

tommycli@chromium.org changed reviewers:
+ blundell@chromium.org, sorin@chromium.org

[tommycli, 2014-09-09 17:31:09]

sorin, blundell: PTAL

Should be last step in componentizing component updater.

As promised, this enables all (now content free) tests on iOS.

[Sorin Jianu, 2014-09-09 18:25:26]

lgtm

Thank you Tommy!

[blundell, 2014-09-10 06:22:57]

LGTM!

BTW, did you already move the code in the component to be in the
component_updater namespace? If not, then there's one more somewhat tedious but
important task :).

https://codereview.chromium.org/555523003/diff/60001/components/component_upd...
File components/component_updater/test/update_response_unittest.cc (right):

https://codereview.chromium.org/555523003/diff/60001/components/component_upd...
components/component_updater/test/update_response_unittest.cc:125: "<g:response
xmlns:g='http://www.google.com/update2/response' protocol='3.0'>"
I assume this change is intentional?

[tommycli, 2014-09-10 16:12:50]

thanks! Yes. everything is already in the component_updater namespace.

https://codereview.chromium.org/555523003/diff/60001/components/component_upd...
File components/component_updater/test/update_response_unittest.cc (right):

https://codereview.chromium.org/555523003/diff/60001/components/component_upd...
components/component_updater/test/update_response_unittest.cc:125: "<g:response
xmlns:g='http://www.google.com/update2/response' protocol='3.0'>"
On 2014/09/10 06:22:57, blundell wrote:
> I assume this change is intentional?

Yes. The previous version was technically incorrect, and causing failure on the
iOS run of the test. Not sure why. the iOS XML parser must be more strict.

[tommycli, 2014-09-10 16:12:53]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-09-10 16:14:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tommycli@chromium.org/555523003/60001

[commit-bot: I haz the power, 2014-09-10 17:14:17]

Committed patchset #4 (id:60001) as 3423da4d28e64d8c6ae7808889a253a63f6afc20

[commit-bot: I haz the power, 2014-09-10 17:16:47]

Patchset 4 (id:??) landed as
https://crrev.com/43754386adfac6ca796478cd0b68947a8be599cb
Cr-Commit-Position: refs/heads/master@{#294184}