Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3871)

Unified Diff: base/files/file.h

Issue 555503007: Cleanup: Get rid of OS_WIN/OS_POSIX ifdefs from MojoApplication (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/file.h
diff --git a/base/files/file.h b/base/files/file.h
index 1913bc7f6c408c8e1e3840da712895ff2fd88259..8277fce931f202d5a820752f7eee73aceb40d59a 100644
--- a/base/files/file.h
+++ b/base/files/file.h
@@ -18,6 +18,7 @@
#include "base/base_export.h"
#include "base/basictypes.h"
+#include "base/files/platform_file.h"
#include "base/files/scoped_file.h"
#include "base/move.h"
#include "base/time/time.h"
@@ -30,17 +31,11 @@ namespace base {
class FilePath;
-#if defined(OS_WIN)
-typedef HANDLE PlatformFile;
-#elif defined(OS_POSIX)
-typedef int PlatformFile;
-
#if defined(OS_BSD) || defined(OS_MACOSX) || defined(OS_NACL)
viettrungluu 2014/09/12 00:12:45 This stuff was all inside the defined(OS_POSIX) bl
Hajime Morrita 2014/09/12 00:39:01 Acknowledged.
typedef struct stat stat_wrapper_t;
#else
typedef struct stat64 stat_wrapper_t;
viettrungluu 2014/09/12 00:12:45 In particular, you shouldn't define this on Window
Hajime Morrita 2014/09/12 00:39:01 Done.
#endif
-#endif // defined(OS_POSIX)
// Thin wrapper around an OS-level file.
// Note that this class does not provide any support for asynchronous IO, other
« no previous file with comments | « base/base.gypi ('k') | base/files/platform_file.h » ('j') | base/files/platform_file.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698