base/files/platform_file.h - Issue 555503007: Cleanup: Get rid of OS_WIN/OS_POSIX ifdefs from MojoApplication

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/files/platform_file.h

Issue 555503007: Cleanup: Get rid of OS_WIN/OS_POSIX ifdefs from MojoApplication (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_FILES_PLATFORM_FILE_H_

	6 #define BASE_FILES_PLATFORM_FILE_H_

	7

	8 #include "build/build_config.h"
	brettw 2014/09/16 17:22:03 Blank line after this. Blank line after this. Hajime Morrita 2014/09/16 17:50:23 Done. Show quoted text On 2014/09/16 17:22:03, brettw wrote: > Blank line after this. Done.
	9 #if defined(OS_WIN)

	10 #include <windows.h>

	11 #endif

	12

	13 namespace base {

	14

	15 #if defined(OS_WIN)
	brettw 2014/09/16 17:22:03 I would personally find it more clear to but blank I would personally find it more clear to but blank lines around the #preprocessor directives. Hajime Morrita 2014/09/16 17:50:23 Done. Show quoted text On 2014/09/16 17:22:03, brettw wrote: > I would personally find it more clear to but blank lines around the > #preprocessor directives. Done.
	16 typedef HANDLE PlatformFile;

	17 const PlatformFile kInvalidPlatformFile = INVALID_HANDLE_VALUE;

	18 #elif defined(OS_POSIX)

	19 typedef int PlatformFile;

	20 const PlatformFile kInvalidPlatformFile = -1;

	21 #endif // defined(OS_POSIX)

	22

	23 } // namespace base

	24

	25 #endif // BASE_FILES_PLATFORM_FILE_H_

OLD	NEW

« no previous file with comments | « base/files/file.h ('k') | content/browser/mojo/mojo_application_host.cc » ('j') | no next file with comments »