Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 555503006: Add cflags for GCC 4.8 builds on Android. (Closed)

Created:
6 years, 3 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 3 months ago
Reviewers:
pasko, Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add cflags for GCC 4.8 builds on Android. This reinstates cflags we used for GCC 4.8 for WebView builds. BUG=407545 NOTRY=true Committed: https://crrev.com/c16332e8e1f6bc14d452a3d0d6201fca57f1a2d9 Cr-Commit-Position: refs/heads/master@{#293935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Fabrice (no longer in Chrome)
6 years, 3 months ago (2014-09-09 12:11:12 UTC) #2
pasko
lgtm
6 years, 3 months ago (2014-09-09 13:05:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/555503006/1
6 years, 3 months ago (2014-09-09 13:14:22 UTC) #5
Torne
The compiler issues seem to be happening on gcc 4.9 on arm64 as well, so ...
6 years, 3 months ago (2014-09-09 13:19:34 UTC) #7
Torne
On 2014/09/09 13:19:34, Torne wrote: > The compiler issues seem to be happening on gcc ...
6 years, 3 months ago (2014-09-09 13:54:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/555503006/1
6 years, 3 months ago (2014-09-09 13:55:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1241fbf1622516f34b48a7a977e4cca8f6aaa76a
6 years, 3 months ago (2014-09-09 13:56:29 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c16332e8e1f6bc14d452a3d0d6201fca57f1a2d9
Cr-Commit-Position: refs/heads/master@{#293935}

Powered by Google App Engine
This is Rietveld 408576698