Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 555503004: Set appropriate working directory on build failure (Closed)

Created:
6 years, 3 months ago by prasadv
Modified:
6 years, 3 months ago
Reviewers:
qyearsley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set appropriate working directory on build failure. Bisect working directory was not reset on build failures, because of this svn commands were executed in wrong directory. BUG=391109 NOTRY=true Committed: https://crrev.com/f0b61609929172b2b1cf619342105ab4ee53542d Cr-Commit-Position: refs/heads/master@{#293942}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/bisect-perf-regression.py View 2 chunks +6 lines, -6 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
prasadv
6 years, 3 months ago (2014-09-08 23:00:14 UTC) #2
qyearsley
On 2014/09/08 23:00:14, prasadv wrote: LGTM
6 years, 3 months ago (2014-09-09 00:59:47 UTC) #3
qyearsley
https://codereview.chromium.org/555503004/diff/40001/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/555503004/diff/40001/tools/bisect-perf-regression.py#newcode1530 tools/bisect-perf-regression.py:1530: cwd = os.getcwd() (Note, somewhat unrelated to this CL: ...
6 years, 3 months ago (2014-09-09 00:59:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/555503004/40001
6 years, 3 months ago (2014-09-09 15:35:57 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 22779638be476b1b0b49020f1e7cf23f63f0b983
6 years, 3 months ago (2014-09-09 15:39:06 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:28 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f0b61609929172b2b1cf619342105ab4ee53542d
Cr-Commit-Position: refs/heads/master@{#293942}

Powered by Google App Engine
This is Rietveld 408576698