content/renderer/manifest/manifest_parser.cc - Issue 555493007: Fix ASAN breakage with ManifestParserTest.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/manifest/manifest_parser.cc

Issue 555493007: Fix ASAN breakage with ManifestParserTest.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/manifest/manifest_parser.cc

diff --git a/content/renderer/manifest/manifest_parser.cc b/content/renderer/manifest/manifest_parser.cc

index 163d3432cfa698c30e994a2a9057418563e42ce3..3e08f8c55f995181d8467dd7cf241feb9357d4b5 100644

--- a/content/renderer/manifest/manifest_parser.cc

+++ b/content/renderer/manifest/manifest_parser.cc

@@ -54,7 +54,7 @@ base::NullableString16 ParseShortName(

namespace content {

Manifest ManifestParser::Parse(const base::StringPiece& json) {

- base::Value* value = base::JSONReader::Read(json);

+ scoped_ptr<base::Value> value(base::JSONReader::Read(json));

if (!value) {

// TODO(mlamouri): get the JSON parsing error and report it to the developer

// console.

« no previous file with comments | « no previous file | no next file » | no next file with comments »