Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: Tools/GardeningServer/ui/ct-failure-stream.html

Issue 555493005: [Sheriff-o-matic] Use before content hax to hide category labels instead of ever-present spans (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove premature builders category Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-card.html ('k') | Tools/GardeningServer/ui/ct-unexpected-failures.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-failure-stream.html
diff --git a/Tools/GardeningServer/ui/ct-failure-stream.html b/Tools/GardeningServer/ui/ct-failure-stream.html
index 110f8f1c19ca8483f94f8e895565bf852dec82cd..ff2df73de09adae29b22261672ee26b892e04c74 100644
--- a/Tools/GardeningServer/ui/ct-failure-stream.html
+++ b/Tools/GardeningServer/ui/ct-failure-stream.html
@@ -6,7 +6,7 @@ found in the LICENSE file.
<link rel="import" href="ct-failure-card.html">
-<polymer-element name="ct-failure-stream" attributes="groups commitLog tree category" noscript>
+<polymer-element name="ct-failure-stream" attributes="groups commitLog tree category title" noscript>
<template>
<style>
:host {
@@ -16,10 +16,20 @@ found in the LICENSE file.
ct-failure-card {
margin-bottom: 5px;
padding: 5px;
- border-top: 1px solid lightgrey;
+ border-bottom: 1px solid lightgrey;
+ }
+
+ /* FIXME: Don't use before hax to add labels */
+ ct-failure-card:first-of-type::before {
+ content: "{{ title }}:";
+ display: block;
+ font-weight: bold;
+ font-size: 18px;
+ padding: 5px;
+ background-color: #f5f5f5;
+ margin-bottom: 5px;
}
</style>
- <!-- FIXME: Show a label based on the category when the filtered stream isn't empty -->
<template repeat="{{ group in groups }}">
<template if="{{ group.category == category }}">
<ct-failure-card group="{{ group }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-card>
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-card.html ('k') | Tools/GardeningServer/ui/ct-unexpected-failures.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698