Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 555463006: Eliminated test flakiness for script-priorities (Closed)

Created:
6 years, 3 months ago by Pat Meenan
Modified:
6 years, 3 months ago
Reviewers:
loislo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Eliminated test flakiness for script-priorities The async scripts execute in non-deterministic order so I removed their debug output. The only thing we really care about testing in the script-priorities layout test is the request priority which is determined and logged deterministically at parse time (and still captured). BUG=413604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
A + LayoutTests/http/tests/loading/resources/async.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/loading/resources/defer.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/http/tests/loading/resources/injected.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/loading/resources/injected-async.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/loading/script-priorities.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/loading/script-priorities-expected.txt View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Pat Meenan
loislo@ PTAL (and sorry about the flaky test). This still tests for what we need ...
6 years, 3 months ago (2014-09-12 13:19:10 UTC) #2
loislo
lgtm
6 years, 3 months ago (2014-09-12 13:23:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555463006/1
6 years, 3 months ago (2014-09-12 13:24:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26836)
6 years, 3 months ago (2014-09-12 15:12:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555463006/1
6 years, 3 months ago (2014-09-12 17:04:54 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 17:56:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181919

Powered by Google App Engine
This is Rietveld 408576698