Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: LayoutTests/http/tests/serviceworker/resources/request-worker.js

Issue 555443002: [Fetch API] Put body members directly on Response/Request (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated yhirano's comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/resources/request-worker.js
diff --git a/LayoutTests/http/tests/serviceworker/resources/request-worker.js b/LayoutTests/http/tests/serviceworker/resources/request-worker.js
index 8d5b99604f0bd994bc6dc7f0a1049d0df1156ba5..7f6908330f0723850b65fb4b4d975a7e92b74e0f 100644
--- a/LayoutTests/http/tests/serviceworker/resources/request-worker.js
+++ b/LayoutTests/http/tests/serviceworker/resources/request-worker.js
@@ -303,7 +303,9 @@ async_test(function(t) {
assert_equals(
getContentType(request.headers), 'test/type',
'ContentType header of Request created with Blob body must be set.');
- request.body.asText()
+ assert_false(request.bodyUsed,
+ 'bodyUsed must be true before calling text()');
+ request.text()
.then(function(result) {
assert_equals(result, 'Test Blob',
'Creating a Request with Blob body should success.');
@@ -312,7 +314,7 @@ async_test(function(t) {
assert_equals(
getContentType(request.headers), 'text/plain;charset=UTF-8',
'ContentType header of Request created with string must be set.');
- return request.body.asText();
+ return request.text();
})
.then(function(result) {
assert_equals(result, 'Test String',
@@ -323,7 +325,7 @@ async_test(function(t) {
for (var i = 0; i < text.length; ++i)
array[i] = text.charCodeAt(i);
request = new Request(URL, {method: 'POST', body: array.buffer});
- return request.body.asText();
+ return request.text();
})
.then(function(result) {
assert_equals(
@@ -335,7 +337,7 @@ async_test(function(t) {
for (var i = 0; i < text.length; ++i)
array[i] = text.charCodeAt(i);
request = new Request(URL, {method: 'POST', body: array});
- return request.body.asText();
+ return request.text();
})
.then(function(result) {
assert_equals(
@@ -348,7 +350,7 @@ async_test(function(t) {
formData.append('sample file',
new File(['file content'], 'file.dat'));
request = new Request(URL, {method: 'POST', body: formData});
- return request.body.asText();
+ return request.text();
})
.then(function(result) {
var reg = new RegExp('multipart\/form-data; boundary=(.*)');
@@ -380,4 +382,6 @@ async_test(function(t) {
t.done();
})
.catch(unreached_rejection(t));
+ assert_true(request.bodyUsed,
+ 'bodyUsed must be true after calling text()');
}, 'Request body test in ServiceWorkerGlobalScope');

Powered by Google App Engine
This is Rietveld 408576698