Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: Source/modules/serviceworkers/Response.h

Issue 555443002: [Fetch API] Put body members directly on Response/Request (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/Response.h
diff --git a/Source/modules/serviceworkers/Response.h b/Source/modules/serviceworkers/Response.h
index b6e6645e62cb5b3dcff41c4ea111758e524c0115..2c8662d5f432119ea8c3ca8b001aa2d203039d84 100644
--- a/Source/modules/serviceworkers/Response.h
+++ b/Source/modules/serviceworkers/Response.h
@@ -7,7 +7,7 @@
#include "bindings/core/v8/Dictionary.h"
#include "bindings/core/v8/ScriptWrappable.h"
-#include "modules/serviceworkers/FetchBodyStream.h"
+#include "modules/serviceworkers/Body.h"
#include "modules/serviceworkers/FetchResponseData.h"
#include "modules/serviceworkers/Headers.h"
#include "platform/blob/BlobData.h"
@@ -22,14 +22,15 @@ class ExceptionState;
class ResponseInit;
class WebServiceWorkerResponse;
-class Response FINAL : public GarbageCollected<Response>, public ScriptWrappable {
+class Response FINAL : public Body {
DEFINE_WRAPPERTYPEINFO();
public:
- static Response* create(Blob*, const Dictionary&, ExceptionState&);
- static Response* create(const String&, const Dictionary&, ExceptionState&);
- static Response* create(Blob*, const ResponseInit&, ExceptionState&);
- static Response* create(FetchResponseData*);
- static Response* create(const WebServiceWorkerResponse&);
+ virtual ~Response() { }
+ static Response* create(ExecutionContext*, Blob*, const Dictionary&, ExceptionState&);
+ static Response* create(ExecutionContext*, const String&, const Dictionary&, ExceptionState&);
+ static Response* create(ExecutionContext*, Blob*, const ResponseInit&, ExceptionState&);
+ static Response* create(ExecutionContext*, FetchResponseData*);
+ static Response* create(ExecutionContext*, const WebServiceWorkerResponse&);
String type() const;
String url() const;
@@ -37,20 +38,19 @@ public:
String statusText() const;
Headers* headers() const;
- FetchBodyStream* body(ExecutionContext*);
-
void populateWebServiceWorkerResponse(WebServiceWorkerResponse&);
- void trace(Visitor*);
+ virtual void trace(Visitor*) OVERRIDE;
private:
- Response();
- explicit Response(FetchResponseData*);
- explicit Response(const WebServiceWorkerResponse&);
+ Response(ExecutionContext*);
jsbell 2014/09/09 22:04:25 single argument constructor should have `explicit`
horo 2014/09/10 06:18:44 Done.
+ Response(ExecutionContext*, FetchResponseData*);
+ Response(ExecutionContext*, const WebServiceWorkerResponse&);
+
+ virtual PassRefPtr<BlobDataHandle> blobDataHandle() OVERRIDE;
Member<FetchResponseData> m_response;
Member<Headers> m_headers;
- Member<FetchBodyStream> m_fetchBodyStream;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698