Issue 555423002: Expose always-on hotword preference via hotwordPrivate API.

Issue 555423002: Expose always-on hotword preference via hotwordPrivate API. (Closed)

Created:
6 years, 3 months ago by Anand Mistry (off Chromium)

Modified:
6 years, 3 months ago

Reviewers:
kcarattini, benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rlp+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Expose always-on hotword preference via hotwordPrivate API. BUG=397019 Committed: https://crrev.com/254dfde35eb81de24afe8c7a2a17bfd067681ccf Cr-Commit-Position: refs/heads/master@{#294314}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
M	chrome/browser/extensions/api/hotword_private/hotword_private_api.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc	View	2 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/hotword_private.idl	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/hotword_private/alwaysOnEnabled/manifest.json	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/hotword_private/alwaysOnEnabled/test.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555423002/1

6 years, 3 months ago (2014-09-11 01:39:13 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as 286cfca7623bd85b0300453c0177239cd4997b35

6 years, 3 months ago (2014-09-11 03:40:22 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-11 03:47:08 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/254dfde35eb81de24afe8c7a2a17bfd067681ccf
Cr-Commit-Position: refs/heads/master@{#294314}