Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 555403003: Define FileManager's properties in the constructor. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Define FileManager's properties in the constructor. - Defined all properties in the constructor. - Prevent adding new properties outside the constructor. - Removed unused properties (searchBoxWrapper_, driveBuyMoreStorageCommand_) BUG=294698 TEST=run browser_tests Committed: https://crrev.com/a8e2fc2bd5b2ded82a4822d40495a07c9773e85f Cr-Commit-Position: refs/heads/master@{#294116}

Patch Set 1 #

Patch Set 2 : Remove a redundant empty line. #

Total comments: 6

Patch Set 3 : Remove unintended blank lines and add bug number for not using Object.seal(). #

Total comments: 2

Patch Set 4 : Remove one more unnecessary empty line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -26 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 15 chunks +556 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
fukino
@hirono, could you take a look? Thanks!
6 years, 3 months ago (2014-09-10 04:24:08 UTC) #2
hirono
cool! https://codereview.chromium.org/555403003/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/555403003/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode497 ui/file_manager/file_manager/foreground/js/file_manager.js:497: The two empty lines are intended? https://codereview.chromium.org/555403003/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode546 ui/file_manager/file_manager/foreground/js/file_manager.js:546: ...
6 years, 3 months ago (2014-09-10 04:33:26 UTC) #3
fukino
Thank you for the comments! https://codereview.chromium.org/555403003/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/555403003/diff/20001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode497 ui/file_manager/file_manager/foreground/js/file_manager.js:497: On 2014/09/10 04:33:25, hirono ...
6 years, 3 months ago (2014-09-10 04:46:06 UTC) #4
hirono
lgtm! https://codereview.chromium.org/555403003/diff/40001/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/555403003/diff/40001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode17 ui/file_manager/file_manager/foreground/js/file_manager.js:17: nit: May be we should remove the line ...
6 years, 3 months ago (2014-09-10 04:50:32 UTC) #5
fukino
Thanks! https://codereview.chromium.org/555403003/diff/40001/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/555403003/diff/40001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode17 ui/file_manager/file_manager/foreground/js/file_manager.js:17: On 2014/09/10 04:50:32, hirono wrote: > nit: May ...
6 years, 3 months ago (2014-09-10 04:54:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/555403003/60001
6 years, 3 months ago (2014-09-10 04:55:55 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 6340501628b347c879e042fe851869b817a658ba
6 years, 3 months ago (2014-09-10 05:58:49 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 06:01:19 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a8e2fc2bd5b2ded82a4822d40495a07c9773e85f
Cr-Commit-Position: refs/heads/master@{#294116}

Powered by Google App Engine
This is Rietveld 408576698