Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 555383004: Use a better c++11 readiness check. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
awong, viettrungluu
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use a better c++11 readiness check. This is like https://codereview.chromium.org/443483002/ , but that check wasn't as convincing as it could have been since clang accepts override and final as an extension in c++98 mode. No intended behavior change. If your bot can't deal with this, please let me know! BUG=none R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/83ea589954286349dfb86cbfb0c9337ae5019108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M base/macros.h View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
(I checked that clang rejects static_assert without -std=gnu++11. The old check wasn't useless, as it ...
6 years, 3 months ago (2014-09-16 18:34:36 UTC) #2
viettrungluu
lgtm
6 years, 3 months ago (2014-09-16 19:06:47 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/83ea589954286349dfb86cbfb0c9337ae5019108 Cr-Commit-Position: refs/heads/master@{#295128}
6 years, 3 months ago (2014-09-16 19:45:05 UTC) #5
Nico
6 years, 3 months ago (2014-09-16 19:45:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 83ea589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698