Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: net/base/data_url_unittest.cc

Issue 555383003: [Regression fix] [Data URI parser] Accept data URI with invalid mediatype data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed InvalidMimeType unittest Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/data_url_unittest.cc
diff --git a/net/base/data_url_unittest.cc b/net/base/data_url_unittest.cc
index 5a5dbe8f008d98c460a48e7f504ffbaebac3c630..c27cc29a931c1d676b51f1cadd0dfdb4f5e7ec52 100644
--- a/net/base/data_url_unittest.cc
+++ b/net/base/data_url_unittest.cc
@@ -63,6 +63,13 @@ TEST(DataURLTest, Parse) {
"US-ASCII",
"hello world" },
+ // Allow token mediatype for backward compatibility
+ { "data:foo,boo",
+ true,
+ "foo",
+ "US-ASCII",
+ "boo" },
+
{ "data:foo/bar;baz=1;charset=kk,boo",
true,
"foo/bar",
@@ -90,10 +97,10 @@ TEST(DataURLTest, Parse) {
// Bad mime type
{ "data:f(oo/bar;baz=1;charset=kk,boo",
- false,
- "",
- "",
- "" },
+ true,
+ "f(oo/bar",
+ "kk",
+ "boo" },
// the comma cannot be url-escaped!
{ "data:%2Cblah",

Powered by Google App Engine
This is Rietveld 408576698