Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: net/url_request/url_request_data_job.cc

Issue 555383003: [Regression fix] [Data URI parser] Accept data URI with invalid mediatype data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed InvalidMimeType unittest Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Simple implementation of a data: protocol handler. 5 // Simple implementation of a data: protocol handler.
6 6
7 #include "net/url_request/url_request_data_job.h" 7 #include "net/url_request/url_request_data_job.h"
8 8
9 #include "net/base/data_url.h" 9 #include "net/base/data_url.h"
10 #include "net/base/mime_util.h"
10 #include "net/base/net_errors.h" 11 #include "net/base/net_errors.h"
11 #include "net/http/http_response_headers.h" 12 #include "net/http/http_response_headers.h"
12 #include "url/gurl.h" 13 #include "url/gurl.h"
13 14
14 namespace net { 15 namespace net {
15 16
16 int URLRequestDataJob::BuildResponse(const GURL& url, 17 int URLRequestDataJob::BuildResponse(const GURL& url,
17 std::string* mime_type, 18 std::string* mime_type,
18 std::string* charset, 19 std::string* charset,
19 std::string* data, 20 std::string* data,
20 HttpResponseHeaders* headers) { 21 HttpResponseHeaders* headers) {
21 if (!net::DataURL::Parse(url, mime_type, charset, data)) 22 if (!net::DataURL::Parse(url, mime_type, charset, data))
22 return net::ERR_INVALID_URL; 23 return net::ERR_INVALID_URL;
23 24
24 // |mime_type| set by net::DataURL::Parse() is guaranteed to be in 25 // |mime_type| set by net::DataURL::Parse() is guaranteed to be in
25 // token "/" token 26 // token "/" token
26 // form. |charset| is also guaranteed to be a token. 27 // form. |charset| is also guaranteed to be a token.
27 28
28 DCHECK(!mime_type->empty()); 29 DCHECK(!mime_type->empty());
29 DCHECK(!charset->empty()); 30 DCHECK(!charset->empty());
30 31
31 if (headers) { 32 if (headers) {
32 headers->ReplaceStatusLine("HTTP/1.1 200 OK"); 33 headers->ReplaceStatusLine("HTTP/1.1 200 OK");
33 // "charset" in the Content-Type header is specified explicitly to follow 34 // "charset" in the Content-Type header is specified explicitly to follow
34 // the "token" ABNF in the HTTP spec. When DataURL::Parse() call is 35 // the "token" ABNF in the HTTP spec. When DataURL::Parse() call is
35 // successful, it's guaranteed that the string in |charset| follows the 36 // successful, it's guaranteed that the string in |charset| follows the
36 // "token" ABNF. 37 // "token" ABNF.
37 std::string content_type_header = 38 if (ParseMimeTypeWithoutParameter(*mime_type, NULL, NULL)) {
38 "Content-Type: " + *mime_type + ";charset=" + *charset; 39 std::string content_type_header =
39 headers->AddHeader(content_type_header); 40 "Content-Type: " + *mime_type + ";charset=" + *charset;
41 headers->AddHeader(content_type_header);
42 }
40 headers->AddHeader("Access-Control-Allow-Origin: *"); 43 headers->AddHeader("Access-Control-Allow-Origin: *");
41 } 44 }
42 45
43 return net::OK; 46 return net::OK;
44 } 47 }
45 48
46 URLRequestDataJob::URLRequestDataJob( 49 URLRequestDataJob::URLRequestDataJob(
47 URLRequest* request, NetworkDelegate* network_delegate) 50 URLRequest* request, NetworkDelegate* network_delegate)
48 : URLRequestSimpleJob(request, network_delegate) { 51 : URLRequestSimpleJob(request, network_delegate) {
49 } 52 }
(...skipping 10 matching lines...) Expand all
60 63
61 // TODO(tyoshino): Get the headers and export via 64 // TODO(tyoshino): Get the headers and export via
62 // URLRequestJob::GetResponseInfo(). 65 // URLRequestJob::GetResponseInfo().
63 return BuildResponse(url, mime_type, charset, data, NULL); 66 return BuildResponse(url, mime_type, charset, data, NULL);
64 } 67 }
65 68
66 URLRequestDataJob::~URLRequestDataJob() { 69 URLRequestDataJob::~URLRequestDataJob() {
67 } 70 }
68 71
69 } // namespace net 72 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698