Issue 555373005: Revert "Safebrowsing: allow sending enhanced download protection pings on OSX."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555373005: Revert "Safebrowsing: allow sending enhanced download protection pings on OSX." (Closed)

Created:
6 years, 3 months ago by mattm

Modified:
6 years, 3 months ago

Reviewers:
noé

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Safebrowsing: allow sending enhanced download protection pings on OSX." unit_tests failing on bots even though they passed the CQ. This reverts commit d117e91057252e860a551fbe62b7e4446c872828. BUG=413967 TBR=noelutz@chromium.org Committed: https://crrev.com/a0d3f6781193aca6a48a3ff24577a724d05240e9 Cr-Commit-Position: refs/heads/master@{#295213}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -43 lines)			Patch
M	chrome/browser/safe_browsing/download_protection_service.cc	View	4 chunks	+7 lines, -22 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View	5 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/common/safe_browsing/csd.proto	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/safe_browsing/download_protection_util.cc	View	3 chunks	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/a0d3f6781193aca6a48a3ff24577a724d05240e9 Cr-Commit-Position: refs/heads/master@{#295213}

6 years, 3 months ago (2014-09-17 01:54:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as a0d3f67.

Expand Messages | Collapse Messages