Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 555373003: Make the ServiceProvider& arg to GetServiceProviderForFrame non-nullable. (Closed)

Created:
6 years, 3 months ago by Sam McNally
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the ServiceProvider& arg to GetServiceProviderForFrame non-nullable. This call isn't meaningful with a null ServiceProvider&. BUG=407683 Committed: https://crrev.com/afd3e88bf107971191bc5f45d24f7ba3b8106854 Cr-Commit-Position: refs/heads/master@{#294276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/render_frame_setup.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
6 years, 3 months ago (2014-09-10 08:20:40 UTC) #2
darin (slow to review)
lgtm
6 years, 3 months ago (2014-09-10 15:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555373003/1
6 years, 3 months ago (2014-09-10 23:50:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 048687c14c14d431979d9562890c006244e7dfc4
6 years, 3 months ago (2014-09-11 00:52:27 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:55:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afd3e88bf107971191bc5f45d24f7ba3b8106854
Cr-Commit-Position: refs/heads/master@{#294276}

Powered by Google App Engine
This is Rietveld 408576698