Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 555373002: Revert of Update metrics verification for dev-proxy. (Closed)

Created:
6 years, 3 months ago by Michael Courage
Modified:
6 years, 3 months ago
Reviewers:
bengr, bolian
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update metrics verification for dev-proxy. (patchset #3 id:80001 of https://codereview.chromium.org/553543004/) Reason for revert: This appears to have made ChromeProxyMetricsTest.testChromeProxyMetricForHeaderValidation fail in Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15658/steps/chrome_proxy/logs/stdio Traceback (most recent call last): run at /usr/lib/python2.7/unittest/case.py:327 testMethod() testChromeProxyMetricForHeaderValidation at tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py:143 metric.AddResultsForHeaderValidation(None, results) AddResultsForHeaderValidation at tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:146 bypassed, _ = self.IsProxyBypassed(tab) IsProxyBypassed at tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:167 bad_proxies = [str(p['proxy']) for p in info['badProxies']] KeyError: 'badProxies' Locals: info : {'proxies': ['compress.googlezip.net:80', 'direct://'], 'enabled': True} tab : None Original issue's description: > Update metrics verification for dev-proxy. > Remove http://aws1.mdw.la/piatek/bypass-demo, which is not bypassed by the server now. > > BUG=412497 > > Committed: https://chromium.googlesource.com/chromium/src/+/0bae38f3f8525a2b49d6df9f7152e1cc130851b1 TBR=bengr@chromium.org,bolian@chromium.org NOTREECHECKS=true NOTRY=true BUG=412497 Committed: https://crrev.com/5d19ad1b49adc1d0417f15a5751903555016dfa9 Cr-Commit-Position: refs/heads/master@{#294065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 5 chunks +14 lines, -25 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/bypass.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Courage
Created Revert of Update metrics verification for dev-proxy.
6 years, 3 months ago (2014-09-10 00:57:10 UTC) #1
bolian
lgtm.
6 years, 3 months ago (2014-09-10 00:59:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/555373002/1
6 years, 3 months ago (2014-09-10 01:09:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3cbfdd98fa5b7c60740ae157f6b91c75fd6f7883
6 years, 3 months ago (2014-09-10 01:27:08 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d19ad1b49adc1d0417f15a5751903555016dfa9
Cr-Commit-Position: refs/heads/master@{#294065}

Powered by Google App Engine
This is Rietveld 408576698