DescriptionRevert of Update metrics verification for dev-proxy. (patchset #3 id:80001 of https://codereview.chromium.org/553543004/)
Reason for revert:
This appears to have made ChromeProxyMetricsTest.testChromeProxyMetricForHeaderValidation fail in Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15658/steps/chrome_proxy/logs/stdio
Traceback (most recent call last):
run at /usr/lib/python2.7/unittest/case.py:327
testMethod()
testChromeProxyMetricForHeaderValidation at tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py:143
metric.AddResultsForHeaderValidation(None, results)
AddResultsForHeaderValidation at tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:146
bypassed, _ = self.IsProxyBypassed(tab)
IsProxyBypassed at tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:167
bad_proxies = [str(p['proxy']) for p in info['badProxies']]
KeyError: 'badProxies'
Locals:
info : {'proxies': ['compress.googlezip.net:80', 'direct://'], 'enabled': True}
tab : None
Original issue's description:
> Update metrics verification for dev-proxy.
> Remove http://aws1.mdw.la/piatek/bypass-demo, which is not bypassed by the server now.
>
> BUG=412497
>
> Committed: https://chromium.googlesource.com/chromium/src/+/0bae38f3f8525a2b49d6df9f7152e1cc130851b1
TBR=bengr@chromium.org,bolian@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=412497
Committed: https://crrev.com/5d19ad1b49adc1d0417f15a5751903555016dfa9
Cr-Commit-Position: refs/heads/master@{#294065}
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|