Add extension permissions for new settings override API.

chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Index: chrome/common/extensions/permissions/settings_override_permission_unittest.cc
diff --git a/chrome/common/extensions/permissions/settings_override_permission_unittest.cc b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d881506a82926b20abb103299110f313045d9a83
--- /dev/null
+++ b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc
@@ -0,0 +1,117 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// These tests make sure SettingsOverridePermission values are set correctly.
+
+#include "base/basictypes.h"
+#include "base/values.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include "chrome/common/extensions/permissions/permissions_data.h"
+#include "chrome/common/extensions/permissions/settings_override_permission.h"
+#include "extensions/common/manifest_constants.h"
+#include "extensions/common/permissions/permission_set.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+class SettingsOverridePermissionTest : public ExtensionManifestTest {
+ protected:
+  enum Flags {
+    kHomePage = 1,
+    kStartupPages = 1 << 1,
+    kSearchProvider = 1 << 2,
+  };
+
+  scoped_refptr<const PermissionSet> GetPermissionSet(uint32 flags) {
+    base::DictionaryValue ext_manifest;
+    ext_manifest.SetString(manifest_keys::kName, "test");
+    ext_manifest.SetString(manifest_keys::kVersion, "0.1");
+    ext_manifest.SetInteger(manifest_keys::kManifestVersion, 2);
+
+    scoped_ptr<base::DictionaryValue> settings_override(
+        new base::DictionaryValue);
+    if (flags & kHomePage)
+      settings_override->SetString("homepage", "http://www.google.com");
+    if (flags & kStartupPages) {
+      scoped_ptr<ListValue> startup_pages(new ListValue);
+      startup_pages->AppendString("http://startup.com/startup.html");
+      settings_override->Set("startup_pages", startup_pages.release());
+    }
+    if (flags & kSearchProvider) {
+      scoped_ptr<DictionaryValue> search_provider(new DictionaryValue);
+      search_provider->SetString("search_url", "http://google.com/search.html");
+      search_provider->SetString("name", "test");
+      search_provider->SetString("keyword", "lock");
+      search_provider->SetString("encoding", "UTF-8");
+      search_provider->SetBoolean("is_default", true);
+      search_provider->SetString("favicon_url", "wikipedia.org/wiki/Favicon");
+      settings_override->Set("search_provider", search_provider.release());
+    }
+    ext_manifest.Set(
+        manifest_keys::kSettingsOverride, settings_override.release());
+
+    Manifest manifest(&ext_manifest, "test");
+    scoped_refptr<extensions::Extension> extension =
+        LoadAndExpectSuccess(manifest);
+    return extension->GetActivePermissions();
+  }
+};
+
+TEST_F(SettingsOverridePermissionTest, HomePage) {
+  scoped_refptr<const PermissionSet> permission_set(
+      GetPermissionSet(kHomePage));
+  DCHECK(permission_set);
+
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomePage));

[Yoyo Zhou, 2013/11/05 21:11:06]

Consider testing the contents of GetWarningMessages to make sure they contain
the correct custom messages.

[MAD, 2013/11/06 13:56:33]

Done.

+  EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
+  EXPECT_FALSE(permission_set->HasAPIPermission(
+      APIPermission::kSearchProvider));
+}
+
+TEST_F(SettingsOverridePermissionTest, SartupPages) {
+  scoped_refptr<const PermissionSet> permission_set(
+      GetPermissionSet(kStartupPages));
+  DCHECK(permission_set);
+
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
+  EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomePage));
+  EXPECT_FALSE(permission_set->HasAPIPermission(
+      APIPermission::kSearchProvider));
+}
+
+TEST_F(SettingsOverridePermissionTest, SearchSettings) {
+  scoped_refptr<const PermissionSet> permission_set(
+      GetPermissionSet(kSearchProvider));
+  DCHECK(permission_set);
+
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
+  EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomePage));
+  EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
+}
+
+TEST_F(SettingsOverridePermissionTest, All) {
+  scoped_refptr<const PermissionSet> permission_set(
+      GetPermissionSet(kSearchProvider | kStartupPages | kHomePage));
+  DCHECK(permission_set);
+
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomePage));
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
+}
+
+TEST_F(SettingsOverridePermissionTest, Some) {
+  scoped_refptr<const PermissionSet> permission_set(
+      GetPermissionSet(kSearchProvider | kHomePage));
+  DCHECK(permission_set);
+
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
+  EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomePage));
+  EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
+}
+
+}  // namespace
+
+}  // namespace extensions