Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 55533003: Add extension permissions for new settings override API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Trimmed schema/www. and only show one start page. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/chrome_api_permissions.cc
diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc
index 0fe74ed8f07c211fca79cd43e0fd6b3b748c0c15..65d88e070a5c6736a1f008b3b4b750a4421fa789 100644
--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc
+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc
@@ -347,6 +347,23 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()
{ APIPermission::kFullscreen, "fullscreen" },
{ APIPermission::kAudio, "audio" },
{ APIPermission::kWebRtc, "webrtc" },
+
+ // Settings override permissions.
+ { APIPermission::kHomePage, "homePage",
+ APIPermissionInfo::kFlagCannotBeOptional |
+ APIPermissionInfo::kFlagInternal,
gab 2013/11/01 22:35:40 Why internal? Is that how we make sure extensions
MAD 2013/11/03 02:21:20 This is what "internal" actually means, it means w
+ IDS_EXTENSION_PROMPT_WARNING_HOME_PAGE_SETTING_OVERRIDE,
+ PermissionMessage::kHomePage },
+ { APIPermission::kSearchSettings, "searchSettings",
+ APIPermissionInfo::kFlagCannotBeOptional |
+ APIPermissionInfo::kFlagInternal,
+ IDS_EXTENSION_PROMPT_WARNING_SEARCH_SETTINGS_OVERRIDE,
+ PermissionMessage::kSearchSettings },
+ { APIPermission::kStartupPages, "startupPages",
gab 2013/11/01 22:35:40 Other comments suggest this can only be 1 page; so
MAD 2013/11/03 02:21:20 Yes, but the manifest format calls this property s
+ APIPermissionInfo::kFlagCannotBeOptional |
+ APIPermissionInfo::kFlagInternal,
+ IDS_EXTENSION_PROMPT_WARNING_START_PAGE_SETTING_OVERRIDE,
+ PermissionMessage::kStartupPages },
};
std::vector<APIPermissionInfo*> permissions;

Powered by Google App Engine
This is Rietveld 408576698