Add extension permissions for new settings override API.

chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler.h"
 
+#include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/common/extensions/permissions/permissions_data.h"
+#include "chrome/common/extensions/permissions/settings_override_permission.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/manifest_constants.h"
+#include "extensions/common/permissions/api_permission_set.h"
+#include "extensions/common/permissions/permissions_info.h"
+#include "url/gurl.h"
 
 using extensions::api::manifest_types::ChromeSettingsOverrides;
 
 namespace extensions {
 namespace {
 
+const char* kWwwPrefix = "www.";
+
 scoped_ptr<GURL> CreateManifestURL(const std::string& url) {
   scoped_ptr<GURL> manifest_url(new GURL(url));
   if (!manifest_url->is_valid() ||
       !manifest_url->SchemeIsHTTPOrHTTPS())
     return scoped_ptr<GURL>();
   return manifest_url.Pass();
 }
 
 scoped_ptr<GURL> ParseHomepage(const ChromeSettingsOverrides& overrides,
                                string16* error) {
@@ skipping 21 matching lines @@
       *error = extensions::ErrorUtils::FormatErrorMessageUTF16(
           manifest_errors::kInvalidStartupOverrideURL, *i);
     } else {
       urls.push_back(GURL());
       urls.back().Swap(manifest_url.get());
     }
   }
   return urls;
 }
 
+std::string RemoveWwwPrefix(const std::string& url) {
+  if (StartsWithASCII(url, kWwwPrefix, false))
+    return url.substr(strlen(kWwwPrefix));
+  return url;
+}
+
 }  // namespace
 
 SettingsOverrides::SettingsOverrides() {}
 
 SettingsOverrides::~SettingsOverrides() {}
 
 const SettingsOverrides* SettingsOverrides::Get(
     const Extension* extension) {
   return static_cast<SettingsOverrides*>(
       extension->GetManifestData(manifest_keys::kSettingsOverride));
@@ skipping 12 matching lines @@
     return false;
 
   scoped_ptr<SettingsOverrides> info(new SettingsOverrides);
   info->homepage = ParseHomepage(*settings, error);
   info->search_engine = settings->search_provider.Pass();
   info->startup_pages = ParseStartupPage(*settings, error);
   if (!info->homepage && !info->search_engine && info->startup_pages.empty()) {
     *error = ASCIIToUTF16(manifest_errors::kInvalidEmptySettingsOverrides);
     return false;
   }
+  APIPermissionSet* permission_set =
+      PermissionsData::GetInitialAPIPermissions(extension);
+  DCHECK(permission_set);
+  if (info->search_engine) {
+    permission_set->insert(new SettingsOverrideAPIPermission(
+        PermissionsInfo::GetInstance()->GetByID(APIPermission::kSearchSettings),
+        RemoveWwwPrefix(CreateManifestURL(info->search_engine->search_url)->

[robertshield, 2013/11/04 01:11:13]

Please add a comment or a note in the changelist description explaining why the
www. prefix is removed here (and not any other prefix, euch as say
http://search.yahoo.com/).

[MAD, 2013/11/04 02:06:34]

Done.

+            GetOrigin().host())));
+  }
+  if (!info->startup_pages.empty()) {
+    permission_set->insert(new SettingsOverrideAPIPermission(
+        PermissionsInfo::GetInstance()->GetByID(APIPermission::kStartupPages),
+        // We only support one startup page.
+        RemoveWwwPrefix(info->startup_pages[0].GetContent())));
+  }
+  if (info->homepage) {
+    permission_set->insert(new SettingsOverrideAPIPermission(
+        PermissionsInfo::GetInstance()->GetByID(APIPermission::kHomePage),
+        RemoveWwwPrefix(info->homepage.get()->GetContent())));
+  }
   extension->SetManifestData(manifest_keys::kSettingsOverride,
                              info.release());
   return true;
 }
 
 const std::vector<std::string> SettingsOverridesHandler::Keys() const {
   return SingleKey(manifest_keys::kSettingsOverride);
 }
 
 }  // namespace extensions