Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tests/corelib/corelib.status

Issue 55533002: Fix some corelib tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Minor updates Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/corelib/collection_to_string_test.dart ('k') | tests/corelib/iterable_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/corelib.status
diff --git a/tests/corelib/corelib.status b/tests/corelib/corelib.status
index 4ab39bbc511ca0d299231da156beb7511fb900f0..de0b551340c45082159d3668780ac8f0d41b9c19 100644
--- a/tests/corelib/corelib.status
+++ b/tests/corelib/corelib.status
@@ -122,18 +122,10 @@ list_as_map_test: Pass, Slow # TODO(kasperl): Please triage.
compare_to2_test: Fail # inherited from VM
unicode_test: Fail # inherited from VM
-# Library changes
-[ $compiler == none || $compiler == dart2js || $compiler == dart2dart ]
-map_keys2_test: RuntimeError # Generic types aren't right.
-
-[ $compiler == dart2js ]
-map_values2_test: RuntimeError # Generic types aren't right
-
-## Tests failing after merge of experimental library branch.
[ $compiler == dart2js ]
-# Tests fail due to bug in generics on constants, issue 6827
-iterable_to_list_test: RuntimeError
-iterable_to_set_test: RuntimeError
+map_values2_test: RuntimeError # Issue 8210
+iterable_to_list_test: RuntimeError # Issue 8210
+iterable_to_set_test: RuntimeError # Issue 8210
[ $compiler == dart2dart && $minified ]
error_stack_trace1_test: Fail # Fails in minified mode, test depends on method names.
@@ -170,12 +162,8 @@ collection_length_test: Pass, Timeout
collection_to_string_test: Pass, Crash # Issue: 11207
[ $compiler == dartanalyzer || $compiler == dart2analyzer ]
-collection_to_string_test: StaticWarning
-error_stack_trace_test: StaticWarning
-iterable_element_at_test: StaticWarning
-iterable_test: StaticWarning
-list_map_test: StaticWarning
-num_clamp_test: StaticWarning
-queue_test: StaticWarning
-string_codeunits_test: StaticWarning
-string_test: StaticWarning
+error_stack_trace_test: StaticWarning, OK # Test generates errors on purpose.
+iterable_element_at_test: StaticWarning, OK # Test generates errors on purpose.
+num_clamp_test: StaticWarning, OK # Test generates errors on purpose.
+queue_test: StaticWarning # Issue 12274.
+string_test: StaticWarning, OK # Test generates error on purpose.
« no previous file with comments | « tests/corelib/collection_to_string_test.dart ('k') | tests/corelib/iterable_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698