Issue 555323003: webkit: Cleanup: Delete webkit_common_export.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555323003: webkit: Cleanup: Delete webkit_common_export.h (Closed)

Created:
6 years, 3 months ago by tfarina

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org, pilgrim_google, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

webkit: Cleanup: Delete webkit_common_export.h After recent refactorings moving almost the remaining pieces into storage/, looks like nobody is including this header. So we can remove it now. BUG=338338 TEST=None TBR=jamesr@chromium.org Committed: https://crrev.com/f5aa19be61458826c1465a992f6513fa97883b58 Cr-Commit-Position: refs/heads/master@{#294333}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -29 lines)			Patch
	D	webkit/common/webkit_common_export.h	View		1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555323003/1

6 years, 3 months ago (2014-09-11 03:18:16 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as bf46b2da344dcf801a1ca03efb7b7cc359ff008a

6 years, 3 months ago (2014-09-11 06:01:00 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-11 06:02:33 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f5aa19be61458826c1465a992f6513fa97883b58
Cr-Commit-Position: refs/heads/master@{#294333}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages