Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3040)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 555323002: Deprecate direct use of legacy extension management preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 6b05504d05c6ae629a58219bc967fdd244624975..9e521842259bd4950e00469a94e5e32636771aa7 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -172,6 +172,7 @@ ExtensionSettingsHandler::ExtensionSettingsHandler()
error_console_observer_(this),
extension_prefs_observer_(this),
extension_registry_observer_(this),
+ extension_management_observer_(this),
should_do_verification_check_(false) {
}
@@ -191,6 +192,7 @@ ExtensionSettingsHandler::ExtensionSettingsHandler(ExtensionService* service,
error_console_observer_(this),
extension_prefs_observer_(this),
extension_registry_observer_(this),
+ extension_management_observer_(this),
should_do_verification_check_(false) {
}
@@ -748,6 +750,10 @@ void ExtensionSettingsHandler::OnExtensionDisableReasonsChanged(
MaybeUpdateAfterNotification();
}
+void ExtensionSettingsHandler::OnExtensionManagementSettingsChanged() {
+ MaybeUpdateAfterNotification();
+}
+
void ExtensionSettingsHandler::ExtensionUninstallAccepted() {
DCHECK(!extension_id_prompting_.empty());
@@ -1266,12 +1272,8 @@ void ExtensionSettingsHandler::MaybeRegisterForNotifications() {
error_console_observer_.Add(ErrorConsole::Get(profile));
- base::Closure callback = base::Bind(
- &ExtensionSettingsHandler::MaybeUpdateAfterNotification,
- AsWeakPtr());
-
- pref_registrar_.Init(profile->GetPrefs());
- pref_registrar_.Add(pref_names::kInstallDenyList, callback);
+ extension_management_observer_.Add(
+ ExtensionManagementFactory::GetForBrowserContext(profile));
}
std::vector<ExtensionPage>

Powered by Google App Engine
This is Rietveld 408576698