Deprecate direct use of legacy extension management preference

chrome/browser/extensions/extension_management.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
@@ skipping 76 matching lines @@
           forcelist.get(), it->first, it->second.update_url);
     }
   }
   return forcelist.Pass();
 }
 
 bool ExtensionManagement::IsInstallationAllowed(const ExtensionId& id) const {
   return ReadById(id).installation_mode != INSTALLATION_BLOCKED;
 }
 
+bool ExtensionManagement::IsOffstoreInstallAllowed(const GURL& url,
+                                                   const GURL& referrer_url) {
+  // No allowed install sites specified, disallow by default.
+  if (!global_settings_.has_restricted_install_sources) {
+    return false;
+  }
+
+  const extensions::URLPatternSet& url_patterns =
+      global_settings_.install_sources;
+
+  if (!url_patterns.MatchesURL(url))
+    return false;
+
+  // The referrer URL must also be whitelisted, unless the URL has the file
+  // scheme (there's no referrer for those URLs).
+  return url_patterns.MatchesURL(referrer_url) || url.SchemeIsFile();

[Joao da Silva, 2014/09/12 13:18:40]

invert the order of these 2 tests: if the scheme is file then there is no need
to call MatchesURL

+}
+
 const ExtensionManagement::IndividualSettings& ExtensionManagement::ReadById(
     const ExtensionId& id) const {
   DCHECK(crx_file::id_util::IdIsValid(id)) << "Invalid ID: " << id;
   SettingsIdMap::const_iterator it = settings_by_id_.find(id);
   if (it != settings_by_id_.end())
     return it->second;
   return default_settings_;
 }
 
 const ExtensionManagement::GlobalSettings&
@@ skipping 162 matching lines @@
   return new ExtensionManagement(
       Profile::FromBrowserContext(context)->GetPrefs());
 }
 
 content::BrowserContext* ExtensionManagementFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }
 
 }  // namespace extensions