Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 555313002: Cleanup: Use base/files/file_util.h instead of base/file_util.h in ash/, athena/, and chromeos/ (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, sadrul, hashimoto+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Use base/files/file_util.h instead of base/file_util.h in ash/, athena/, and chromeos/ TBR=pneubeck@chromium.org Committed: https://crrev.com/b44bd35d96e7367529c6053b68226d10fd9e9dc2 Cr-Commit-Position: refs/heads/master@{#294072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M ash/desktop_background/desktop_background_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/system/orientation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/accelerometer/accelerometer_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/cert_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/session_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/client_cert_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_cert_migrator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/process_proxy/process_output_watcher_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/settings/timezone_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/name_value_pairs_parser.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Lei Zhang
Files with diffs that are not +1/-1 have some lint cleanup.
6 years, 3 months ago (2014-09-09 21:52:40 UTC) #2
oshima
lgtm
6 years, 3 months ago (2014-09-09 22:00:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/555313002/1
6 years, 3 months ago (2014-09-09 22:06:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9786)
6 years, 3 months ago (2014-09-09 22:16:40 UTC) #7
Lei Zhang
TBR pneubeck for trivial changes in chromeos/network
6 years, 3 months ago (2014-09-09 22:17:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/555313002/1
6 years, 3 months ago (2014-09-09 22:19:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as ce3ab4c18f7bd053fdc2cccd507a172d7a160b12
6 years, 3 months ago (2014-09-10 01:48:10 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b44bd35d96e7367529c6053b68226d10fd9e9dc2 Cr-Commit-Position: refs/heads/master@{#294072}
6 years, 3 months ago (2014-09-10 03:57:37 UTC) #13
pneubeck (no reviews)
6 years, 3 months ago (2014-09-10 11:54:48 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698