Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 555283006: Rework format-webkitpy to use single-quoting for chromium, add more args. (Closed)

Created:
6 years, 3 months ago by Dirk Pranke
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Rework format-webkitpy to use single-quoting for chromium, add more args. In addition to changing the default for the chromium coding style to use single-quoted string literals instead of double, this reworks the structure of the program to be a bit clearer, and adds command line args to toggle on and off the autopep8 reformatting and the string literal reformatting. TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181767

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -50 lines) Patch
M Tools/Scripts/webkitpy/formatter/main.py View 1 chunk +53 lines, -33 lines 2 comments Download
M Tools/Scripts/webkitpy/formatter/main_unittest.py View 2 chunks +40 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
6 years, 3 months ago (2014-09-10 19:55:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/555283006/1
6 years, 3 months ago (2014-09-10 19:56:22 UTC) #3
eseidel
lgtm https://codereview.chromium.org/555283006/diff/1/Tools/Scripts/webkitpy/formatter/main.py File Tools/Scripts/webkitpy/formatter/main.py (right): https://codereview.chromium.org/555283006/diff/1/Tools/Scripts/webkitpy/formatter/main.py#newcode26 Tools/Scripts/webkitpy/formatter/main.py:26: parser.add_argument('--leave-strings-alone', action='store_true', I might have made this a ...
6 years, 3 months ago (2014-09-10 20:50:36 UTC) #4
Dirk Pranke
https://codereview.chromium.org/555283006/diff/1/Tools/Scripts/webkitpy/formatter/main.py File Tools/Scripts/webkitpy/formatter/main.py (right): https://codereview.chromium.org/555283006/diff/1/Tools/Scripts/webkitpy/formatter/main.py#newcode26 Tools/Scripts/webkitpy/formatter/main.py:26: parser.add_argument('--leave-strings-alone', action='store_true', On 2014/09/10 20:50:36, eseidel wrote: > I ...
6 years, 3 months ago (2014-09-10 20:52:05 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 21:02:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181767

Powered by Google App Engine
This is Rietveld 408576698