extensions/extensions.gyp - Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/cast_channel/cast_transport_unittest.cc ('K') | « extensions/browser/api/cast_channel/cast_transport_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index 1ed6ff41bf6517e3a9416c541a03e543f6795162..40138778f1e9a4cfcec8c0b4ad775820527d01c5 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -354,6 +354,10 @@

'browser/api/cast_channel/cast_message_util.h',

'browser/api/cast_channel/cast_socket.cc',

'browser/api/cast_channel/cast_socket.h',

+ 'browser/api/cast_channel/cast_framer.cc',

+ 'browser/api/cast_channel/cast_framer.h',

Wez 2014/09/12 20:23:04 I don't see these file in this CL?

+ 'browser/api/cast_channel/cast_transport.h',

+ 'browser/api/cast_channel/cast_transport.cc',

'browser/api/cast_channel/logger.cc',

'browser/api/cast_channel/logger.h',

'browser/api/cast_channel/logger_util.cc',

@@ -1034,6 +1038,7 @@

'browser/api/cast_channel/cast_channel_api_unittest.cc',

'browser/api/cast_channel/cast_framer_unittest.cc',

'browser/api/cast_channel/cast_socket_unittest.cc',

+ 'browser/api/cast_channel/cast_transport_unittest.cc',

'browser/api/cast_channel/logger_unittest.cc',

'browser/api/declarative/declarative_rule_unittest.cc',

'browser/api/declarative/deduping_factory_unittest.cc',

« extensions/browser/api/cast_channel/cast_transport_unittest.cc ('K') | « extensions/browser/api/cast_channel/cast_transport_unittest.cc ('k') | no next file » | no next file with comments »