extensions/browser/api/cast_channel/cast_socket_unittest.cc - Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket_unittest.cc

Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback addressed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/cast_channel/cast_socket.cc ('K') | « extensions/browser/api/cast_channel/cast_socket.cc ('k') | extensions/browser/api/cast_channel/cast_transport.h » ('j') | extensions/browser/api/cast_channel/cast_transport.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_socket_unittest.cc

diff --git a/extensions/browser/api/cast_channel/cast_socket_unittest.cc b/extensions/browser/api/cast_channel/cast_socket_unittest.cc

index c571850e9d599df24707c05b85a1329229c67228..08ae1170fb540ca514b43e4980dd13678287a451 100644

--- a/extensions/browser/api/cast_channel/cast_socket_unittest.cc

+++ b/extensions/browser/api/cast_channel/cast_socket_unittest.cc

@@ -80,8 +80,8 @@ class MockCastSocketDelegate : public CastSocket::Delegate {

void(const CastSocket* socket,

ChannelError error,

const LastErrors& last_errors));

- MOCK_METHOD2(OnMessage, void(const CastSocket* socket,

- const MessageInfo& message));

+ MOCK_METHOD2(OnMessage,

+ void(const CastSocket* socket, const MessageInfo& message));

};

class MockTCPSocket : public net::TCPClientSocket {

@@ -204,8 +204,7 @@ class TestCastSocket : public CastSocket {

return msg.length() - MessageFramer::MessageHeader::header_size();

}

- virtual ~TestCastSocket() {

- }

+ virtual ~TestCastSocket() {}

// Helpers to set mock results for various operations.

void SetupTcp1Connect(net::IoMode mode, int result) {